>Number:         1128
>Category:       kern
>Synopsis:       vfs_bufstats inconsistently conditionalized
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 19 22:20:04 1995
>Originator:     Ted Lemon
>Organization:
>Release:        July 15, 1995
>Environment:
System: NetBSD toccata 1.0A NetBSD 1.0A (TOCCATA) #158: Wed Jun 14 12:49:57 PDT 1995 mellon@toccata:/sandbox/NetBSD-current/sys/arch/pmax/compile/TOCCATA pmax


>Description:
	vfs_bufstats is compiled conditionally on DIAGNOSTIC, but is called
	conditionally on DEBUG, so if only one is defined, the kernel fails
	to link.
>How-To-Repeat:
>Fix:
RCS file: /a/cvsroot/src/sys/kern/vfs_syscalls.c,v
retrieving revision 1.53
diff -c -r1.53 vfs_syscalls.c
*** vfs_syscalls.c	1995/06/01 22:44:13	1.53
--- vfs_syscalls.c	1995/06/19 04:28:30
***************
*** 436,445 ****
  			vfs_unbusy(mp);
  		}
  	}
! #ifdef DEBUG
  	if (syncprt)
  		vfs_bufstats();
! #endif /* DEBUG */
  	return (0);
  }
  
--- 436,445 ----
  			vfs_unbusy(mp);
  		}
  	}
! #ifdef DIAGNOSTIC
  	if (syncprt)
  		vfs_bufstats();
! #endif /* DIAGNOSTIC */
  	return (0);
  }
  
>Audit-Trail:
>Unformatted: