Subject: kern/1037: doesn't have some names it should have
To: None <gnats-admin@sun-lamp.cs.berkeley.edu>
From: John Kohl <jtk@kolvir.blrc.ma.us>
List: netbsd-bugs
Date: 05/08/1995 15:35:09
>Number:         1037
>Category:       kern
>Synopsis:       <sys/audioio.h> has no text names for encodings
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon May  8 15:35:03 1995
>Originator:     John Kohl
>Organization:
NetBSD Kernel Hackers `R` Us
>Release:        1.0A (-current)
>Environment:
	
System: NetBSD kolvir 1.0A NetBSD 1.0A (KOLVIR) #317: Sun May 7 15:36:22 EDT 1995 jtk@kolvir:/u1/NetBSD-current/src/sys/arch/i386/compile/KOLVIR i386


>Description:
<sys/audioio.h> doesn't have text names defined for the various
encodings, nor for some synthesizer devices.

>How-To-Repeat:
Try to build a program using text names for the encodings (e.g. linear,
ulaw, alaw, ...)

>Fix:

===================================================================
RCS file: sys/RCS/audioio.h,v
retrieving revision 1.1
diff -u -r1.1 sys/audioio.h
--- 1.1	1995/02/21 01:37:22
+++ sys/audioio.h	1995/05/08 22:05:46
@@ -225,6 +225,16 @@
 #define AudioNoff	"off"
 #define AudioNmode	"mode"
 #define AudioNsource	"source"
+#define AudioNfmsynth	"fmsynth"
+#define AudioNwave	"wave"
+#define AudioNmidi	"midi"
+
+#define AudioElinear "linear"
+#define AudioEulaw "ulaw"
+#define AudioEalaw "alaw"
+#define AudioEpcm16 "PCM-16"
+#define AudioEpcm8 "PCM-8"
+#define AudioEadpcm "ADPCM"
 
 #define AudioCInputs	"Inputs"
 #define AudioCOutputs	"Outputs"
===================================================================
RCS file: dev/isa/RCS/sbdsp.c,v
retrieving revision 1.2
diff -u -r1.2 dev/isa/sbdsp.c
--- 1.2	1995/05/07 05:45:33
+++ dev/isa/sbdsp.c	1995/05/08 22:01:27
@@ -1596,7 +1596,7 @@
 	    dip->mixer_class = SB_OUTPUT_CLASS;
 	    dip->prev = AUDIO_MIXER_LAST;
 	    dip->next = AUDIO_MIXER_LAST;
-	    strcpy(dip->label.name, "fmsynth");	/* XXX move to audioio.h */
+	    strcpy(dip->label.name, AudioNfmsynth);
 	    dip->un.v.num_channels = 2;
 	    strcpy(dip->un.v.units.name, AudioNvolume);
 	    break;
>Audit-Trail:
>Unformatted: