Subject: Re: kern/1027: audio device doesn't call to set hardware recording gain correctly
To: John Kohl <jtk@kolvir.blrc.ma.us>
From: Rolf Grossmann <grossman@informatik.tu-muenchen.de>
List: netbsd-bugs
Date: 05/08/1995 15:53:53
Hi,

on Sun, 7 May 1995 07:35:02 +0200 John Kohl wrote 
concerning "kern/1027: audio device doesn't call to set hardware recording 
gain correctly" something like this:

>>Description:
> The audio driver doesn't tag the mixer command to set recording gain
> properly--it needs to set AUDIO_MIXER_VALUE.

I had included this fix with a number of other fixes to audio.c with my
update to the sparc audio driver. It looks like it was left out. There also
is another fix missing, that breaks sound io when using the mixer device
while playing/recording:

diff -c -r1.1.1.4 audio.c
*** 1.1.1.4     1995/04/28 02:23:22
--- audio.c     1995/04/28 22:45:49
***************
*** 1653,1667 ****
        int flags, ifmt;
        struct proc *p;
  {
!       int unit = AUDIOUNIT(dev);
!       struct audio_softc *sc = audio_softc[unit];
!       struct audio_hw_if *hw = sc->hw_if;
!       int s;
  
-       DPRINTF(("mixer: close; unit %d\n", unit));
- 
-       hw->close(sc->hw_hdl);
-       
        return (0);
  }
  
--- 1654,1661 ----
        int flags, ifmt;
        struct proc *p;
  {
!       DPRINTF(("mixer: close.\n"));
  
        return (0);
  }