Subject: kern/976: iBCS2 code won't compile w/out warnings
To: None <gnats-admin@NetBSD.ORG>
From: Rafal Boni <r-boni@uiuc.edu>
List: netbsd-bugs
Date: 04/17/1995 15:50:02
>Number:         976
>Category:       kern
>Synopsis:       minor probs in IBCS2 stuff cause compiler warnings
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 17 15:50:01 1995
>Originator:     Rafal Boni
>Organization:
	...not a chance...
>Release:        SUP'd earlier today (Apr 17th)
>Environment:

System: NetBSD berlin-14.slip.uiuc.edu 1.0A NetBSD 1.0A (RAFAL) #4: Mon Mar 27 13:14:15 CST 1995 rafal@rafal.slip.uiuc.edu:/usr/src/sys/arch/i386/compile/RAFAL i386

	COMPAT_IBCS2 and "CC=cc -Werror" in kernel config file.

>Description:
	Since chris added -Werror to GENERIC and KICKME's config.new files, I
	thought I'd do the same for mine.  Kernel built fine w/the exception 
	of /sys/compat/ibcs2/ibcs2_exec.c

>How-To-Repeat:
	Build kernel with 'makeoptions "CC=cc -Werror"' and 
	'options COMPAT_IBCS2' in it.  See compiler give warning in 
	/sys/compat/ibcs2/ibcs2_exec.c

>Fix:

	Here's a uni-diff: 
	(I stole var. names for missing parameters from COMPAT_SVR4)

--- ibcs2_exec.c~	Mon Apr 17 17:33:13 1995
+++ ibcs2_exec.c	Mon Apr 17 17:31:44 1995
@@ -57,14 +57,16 @@
 				     struct coff_filehdr *, 
 				     struct coff_aouthdr *));
 int exec_ibcs2_coff_setup_stack __P((struct proc *, struct exec_package *));
-void cpu_exec_ibcs2_coff_setup __P((struct proc *, struct exec_package *));
+void cpu_exec_ibcs2_coff_setup __P((int, struct proc *, struct exec_package *,
+					void *));
 
 int exec_ibcs2_xout_prep_nmagic __P((struct proc *, struct exec_package *,
 				     struct xexec *, struct xext *));
 int exec_ibcs2_xout_prep_zmagic __P((struct proc *, struct exec_package *,
 				     struct xexec *, struct xext *));
 int exec_ibcs2_xout_setup_stack __P((struct proc *, struct exec_package *));
-void cpu_exec_ibcs2_xout_setup __P((struct proc *, struct exec_package *));
+void cpu_exec_ibcs2_xout_setup __P((int, struct proc *, struct exec_package *,
+					void *));
 int coff_load_shlib __P((struct proc *, char *, struct exec_package *));
 
 /*
@@ -532,9 +534,11 @@
 }
 
 void
-cpu_exec_ibcs2_coff_setup(p, epp)
+cpu_exec_ibcs2_coff_setup(cmd, p, epp, sp)
+	int cmd;
         struct proc *p;
         struct exec_package *epp;
+	void *sp;
 {
 #if 0
         struct coff_aouthdr *ap;
@@ -583,9 +587,11 @@
 }
 
 void
-cpu_exec_ibcs2_xout_setup(p, epp)
+cpu_exec_ibcs2_xout_setup(cmd, p, epp, sp)
+	int cmd;
         struct proc *p;
         struct exec_package *epp;
+	void *sp;
 {
 
 	return;

>Audit-Trail:
>Unformatted: