Subject: Re: lib/952: "feature" in libskey.a, with fix
To: None <tls@sdinter.net>
From: Chris G Demetriou <Chris_G_Demetriou@LAGAVULIN.PDL.CS.CMU.EDU>
List: netbsd-bugs
Date: 04/11/1995 09:50:44
> >Description:
> 	There is no reason to turn off echo and set the tty modes to dumb
> things when prompting for an S/KEY one-time password.  The enclosed short patch
> will fix libskey.a so that it't not so damned hard to type in the s/key 
> passwords correctly.  It will make the world a better place to live in.

makes sense...

> *** skeysubr.c.orig	Tue Apr 11 03:24:38 1995
> --- skeysubr.c	Tue Apr 11 03:27:26 1995
> ***************
> *** 144,149 ****
> --- 144,163 ----
>       return buf;
>   }
>   
> + char *readskey (buf, n)
> + char *buf;
> + int n;
> + {
> +     fgets (buf, n, stdin);
> + 
> +     rip(buf);
> +     printf ("\n");
> + 
> +     sevenbit (buf);
> + 
> +     return buf;
> + }
> + 
>   set_term () 
>   {
>       fflush(stdout);

actually, is the printf("\n") appropriate?  i wouldn't think so (since
echo is not turned off, the user's newline should be echoed).


thoughts?


chris