>Number:         952
>Category:       lib
>Synopsis:       There is no reason to turn off echo when prompting for an s/key.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people (Library Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 11 02:05:07 1995
>Originator:     Thor Lancelot Simon
>Organization:
"	Wasabi Informatics, Inc."
>Release:        1.0
>Environment:
	
System: NetBSD sioux.sdinter.net 1.0 NetBSD 1.0 (FALLS) #12: Fri Mar 17 08:39:13 CST 1995 root@sioux.sdinter.net:/usr/src/sys/arch/i386/compile/FALLS i386


>Description:
	There is no reason to turn off echo and set the tty modes to dumb
things when prompting for an S/KEY one-time password.  The enclosed short patch
will fix libskey.a so that it't not so damned hard to type in the s/key 
passwords correctly.  It will make the world a better place to live in.

>How-To-Repeat:
	Just log in with s/key.  You'll see what I mean.
>Fix:
	
*** skeylogin.c.orig	Tue Apr 11 03:24:49 1995
--- skeylogin.c	Tue Apr 11 03:27:54 1995
***************
*** 423,429 ****
    fflush (stdout);
   
    printf ("Response: ");
!   readpass (pbuf, sizeof (pbuf));
    rip (pbuf);
   
    /* Is it a valid response? */
--- 423,429 ----
    fflush (stdout);
   
    printf ("Response: ");
!   readskey (pbuf, sizeof (pbuf));
    rip (pbuf);
   
    /* Is it a valid response? */
*** skeysubr.c.orig	Tue Apr 11 03:24:38 1995
--- skeysubr.c	Tue Apr 11 03:27:26 1995
***************
*** 144,149 ****
--- 144,163 ----
      return buf;
  }
  
+ char *readskey (buf, n)
+ char *buf;
+ int n;
+ {
+     fgets (buf, n, stdin);
+ 
+     rip(buf);
+     printf ("\n");
+ 
+     sevenbit (buf);
+ 
+     return buf;
+ }
+ 
  set_term () 
  {
      fflush(stdout);
>Audit-Trail:
>Unformatted: