>Number:         682
>Category:       lib
>Synopsis:       librpcsvc/Makefile's beforeinstall: neglects echo
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people (Library Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan  2 20:50:02 1995
>Originator:     John Hawkinson
>Organization:
MIT
>Release:        1.0
>Environment:
System: NetBSD lola-granola 1.0 NetBSD 1.0 (LOLA-DDB) #61: Mon Jan 2 22:01:10 EST 1995 root@lola-granola:/u1/usr/src/sys/arch/i386/compile/LOLA-DDB i386
Also present in today's -current.

>Description:
	When librpcsvc/Makefile's beforeinstall: target performs
	installs on include files, does so within an @for loop
	which does not contain echo commands. As such, it is not
	obvious what is happening at the time.

	Additionally, the RCS keyword is Id rather than NetBSD.

	It should be noted that this process (installing include
	files) should eventually move to bsd.man.mk; since I'm
	currently running 1.0 and I understand it changes with
	-current, I'll skip that for now.

>How-To-Repeat:
	make install
>Fix:

*** /tmp/Makefile	Mon Jan  2 23:41:02 1995
--- Makefile	Mon Jan  2 23:28:31 1995
***************
*** 1,4 ****
! #	$Id: Makefile,v 1.10 1994/06/14 02:45:56 cgd Exp $
  
  RPCDIR=		${.CURDIR}/src
  .PATH:		${RPCDIR}
--- 1,4 ----
! #	$NetBSD: Makefile,v 1.10 1994/06/14 02:45:56 cgd Exp $
  
  RPCDIR=		${.CURDIR}/src
  .PATH:		${RPCDIR}
***************
*** 21,33 ****
  	install -d -o bin -g bin -m 755 ${DESTDIR}/usr/include/rpcsvc
  	@for i in $(HDRS); do \
  	    cmp -s $$i ${DESTDIR}/usr/include/rpcsvc/$$i > /dev/null 2>&1 || \
! 		install -c -o ${BINOWN} -g ${BINGRP} -m 444 $$i \
! 		${DESTDIR}/usr/include/rpcsvc; \
  	done
  	@for i in $(RPCSRCS); do \
  	    cmp -s ${RPCDIR}/$$i ${DESTDIR}/usr/include/rpcsvc/$$i > /dev/null 2>&1 || \
! 		install -c -o ${BINOWN} -g ${BINGRP} -m 444 ${RPCDIR}/$$i \
! 		${DESTDIR}/usr/include/rpcsvc; \
  	done
  
  # new suffixes have to go afterwards, because bsd.lib.mk clears them
--- 21,35 ----
  	install -d -o bin -g bin -m 755 ${DESTDIR}/usr/include/rpcsvc
  	@for i in $(HDRS); do \
  	    cmp -s $$i ${DESTDIR}/usr/include/rpcsvc/$$i > /dev/null 2>&1 || \
! 		{ j="install -c -o ${BINOWN} -g ${BINGRP} -m 444 $$i \
! 		${DESTDIR}/usr/include/rpcsvc"; \
! 		echo $$j; $$j } \
  	done
  	@for i in $(RPCSRCS); do \
  	    cmp -s ${RPCDIR}/$$i ${DESTDIR}/usr/include/rpcsvc/$$i > /dev/null 2>&1 || \
! 		{ j="install -c -o ${BINOWN} -g ${BINGRP} -m 444
! 		${RPCDIR}/$$i ${DESTDIR}/usr/include/rpcsvc"; \
! 		echo $$j; $$j } \
  	done
  
  # new suffixes have to go afterwards, because bsd.lib.mk clears them
>Audit-Trail:
>Unformatted: