Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: 11.99.2 build failures



    Date:        Sun, 14 Sep 2025 09:55:18 +0200
    From:        Adam <adam%netbsd.org@localhost>
    Message-ID:  <6363A4C0-E153-472A-9981-BBD5252F97CE%netbsd.org@localhost>


  |
  | Adding missing #include fixes the build:
  |
  | --- lib/libterminfo/term_private.h 21 Jun 2020 15:05:23 -0000 1.19
  | +++ lib/libterminfo/term_private.h 14 Sep 2025 07:50:10 -0000
  | @@ -71,6 +71,7 @@
  |   */
  |    #include <sys/types.h>
  | +#include <sys/endian.h>
  |  #include <assert.h>
  |  #include <limits.h>

  | May I commit?

A better fix (assuming it works) would be just <endian.h> which is
the defined source for definitions of those functions/macros
(there are some standardised <sys/foo.h> headers, but <sys/endian.h>
is not one of them).   Tools should not be including non-standard headers.

kre



Home | Main Index | Thread Index | Old Index