Re: Call for testing: New kernel heartbeat(9) checks

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Fri, Jul 07, 2023 at 05:10:33PM +0000, Taylor R Campbell wrote:
> > Date: Fri, 7 Jul 2023 17:56:42 +0200
> > From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
> > 
> > On Fri, Jul 07, 2023 at 01:11:54PM +0000, Taylor R Campbell wrote:
> > > - The magic numbers for debug.crashme.spl_spinout are for evbarm.
> > >   On x86, use IPL_SCHED=7, IPL_VM=6, and IPL_SOFTCLOCK=1.
> 
> Correction: IPL_SOFTCLOCK=2.
> 
> > > 1.	cpuctl offline 0
> > > 	sleep 20
> > > 	cpuctl online 0
> > 
> > With this I get a panic on Xen:
> > [ 225.4605386] panic: kernel diagnostic assertion "kpreempt_disabled()" failed: file "/dsk/l1/misc/bouyer/HEAD/clean/src/sys/kern/kern_heartbeat.c", line 158
> > [...]
> > [  53.5704682] panic: kernel diagnostic assertion "kpreempt_disabled()" failed: file "/dsk/l1/misc/bouyer/HEAD/clean/src/sys/kern/kern_heartbeat.c", line 158
> 
> This was a mistake that arose because I was testing on aarch64 where
> kpreempt_disabled() is always true.  Update and try again, please!
> 
> sys/kern/kern_heartbeat.c 1.2
> sys/kern/subr_xcall.c 1.36

Yes, with these (and using 2 for IPL_SOFTCLOCK) every test pass now.
thanks ! This allowed me to fix a small bug in Xen's clock initialisation
already :)

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--