On 23.09.2019 09:02, Kamil Rytarowski wrote: > On 23.09.2019 08:26, Kamil Rytarowski wrote: >> On 23.09.2019 04:41, NetBSD Test Fixture wrote: >>> This is an automatically generated notice of a NetBSD-current/i386 >>> build failure. >>> >>> The failure occurred on babylon5.netbsd.org, a NetBSD/amd64 host, >>> using sources from CVS date 2019.09.22.23.34.13. >>> >>> An extract from the build.sh output follows: >>> >>> --- dependall-libhfs --- >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/nbctfconvert -g -L VERSION libhfs.o >>> --- dependall-libv7fs --- >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/nbctfconvert -g -L VERSION v7fs_datablock.po >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-objcopy -X v7fs_datablock.po >>> --- v7fs_dirent.pico --- >>> # compile libv7fs/v7fs_dirent.pico >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-gcc -O2 -fno-delete-null-pointer-checks -ffreestanding -fno-strict-aliasing -msoft-float -mno-mmx -mno-sse -mno-avx -msoft-float -mno-mmx -mno-sse -mno-avx -std=gnu99 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wsystem-headers -Wno-traditional -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Werror -Wno-format-zero-length -Wno-pointer-sign -fPIE -fstack-protector -Wstack-protector --param ssp-buffer-size=1 -DV7FS_EI --sysroot=/tmp/bracket/build/2019.09.22.23.34.13-i386/destdir -DCOMPAT_50 -DCOMPAT_60 -DCOMPAT_70 -DCOMPAT_80 -nostdinc -imacros /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include/opt/opt_rumpkernel.h -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs -I. -I/tmp/bracket/build/2019.09.22.23.34.13-i386/sr >>> c/sys/rump/fs/lib/libv7fs/../../../../../common/include -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include/opt -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../../arch -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../.. -DDIAGNOSTIC -DKTRACE -D_FORTIFY_SOURCE=2 -c -fPIC /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../../fs/v7fs/v7fs_dirent.c -o v7fs_dirent.pico >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-objcopy -x v7fs_dirent.pico >>> --- v7fs_dirent.po --- >>> # compile libv7fs/v7fs_dirent.po >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-gcc -O2 -fno-delete-null-pointer-checks -ffreestanding -fno-strict-aliasing -msoft-float -mno-mmx -mno-sse -mno-avx -msoft-float -mno-mmx -mno-sse -mno-avx -std=gnu99 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wsystem-headers -Wno-traditional -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Werror -Wno-format-zero-length -Wno-pointer-sign -fPIE -fstack-protector -Wstack-protector --param ssp-buffer-size=1 -DV7FS_EI --sysroot=/tmp/bracket/build/2019.09.22.23.34.13-i386/destdir -DCOMPAT_50 -DCOMPAT_60 -DCOMPAT_70 -DCOMPAT_80 -nostdinc -imacros /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include/opt/opt_rumpkernel.h -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs -I. -I/tmp/bracket/build/2019.09.22.23.34.13-i386/sr >>> c/sys/rump/fs/lib/libv7fs/../../../../../common/include -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include/opt -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../../arch -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../.. -DDIAGNOSTIC -DKTRACE -D_FORTIFY_SOURCE=2 -c -DGPROF -DPROF -pg -fPIC /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../../fs/v7fs/v7fs_dirent.c -o v7fs_dirent.po >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/nbctfconvert -g -L VERSION v7fs_dirent.po >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-objcopy -X v7fs_dirent.po >>> --- v7fs_endian.pico --- >>> # compile libv7fs/v7fs_endian.pico >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-gcc -O2 -fno-delete-null-pointer-checks -ffreestanding -fno-strict-aliasing -msoft-float -mno-mmx -mno-sse -mno-avx -msoft-float -mno-mmx -mno-sse -mno-avx -std=gnu99 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wsystem-headers -Wno-traditional -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Werror -Wno-format-zero-length -Wno-pointer-sign -fPIE -fstack-protector -Wstack-protector --param ssp-buffer-size=1 -DV7FS_EI --sysroot=/tmp/bracket/build/2019.09.22.23.34.13-i386/destdir -DCOMPAT_50 -DCOMPAT_60 -DCOMPAT_70 -DCOMPAT_80 -nostdinc -imacros /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include/opt/opt_rumpkernel.h -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs -I. -I/tmp/bracket/build/2019.09.22.23.34.13-i386/sr >>> c/sys/rump/fs/lib/libv7fs/../../../../../common/include -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../include/opt -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../../arch -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../.. -DDIAGNOSTIC -DKTRACE -D_FORTIFY_SOURCE=2 -c -fPIC /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs/../../../../fs/v7fs/v7fs_endian.c -o v7fs_endian.pico >>> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-objcopy -x v7fs_endian.pico >>> A failure has been detected in another branch of the parallel make >>> nbmake[8]: stopped in /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs >>> *** [dependall] Error code 2 >>> nbmake[7]: stopped in /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libv7fs >>> 1 error >>> >>> The following commits were made between the last successful build and >>> the failed build: >>> >>> 2019.09.22.22.59.37 christos src/bin/df/df.c,v 1.95 >>> 2019.09.22.22.59.37 christos src/distrib/sets/lists/base/shl.mi,v 1.872 >>> 2019.09.22.22.59.37 christos src/distrib/sets/lists/debug/shl.mi,v 1.229 >>> 2019.09.22.22.59.37 christos src/distrib/sets/lists/modules/ad.arm,v 1.13 >>> 2019.09.22.22.59.37 christos src/distrib/sets/lists/modules/ad.mips,v 1.13 >>> 2019.09.22.22.59.37 christos src/distrib/sets/lists/modules/md.amd64,v 1.81 >>> 2019.09.22.22.59.37 christos src/distrib/sets/lists/modules/md.sparc64,v 1.8 >>> 2019.09.22.22.59.37 christos src/distrib/sets/lists/modules/mi,v 1.126 >>> 2019.09.22.22.59.37 christos src/lib/libc/shlib_version,v 1.285 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/gen/Makefile.inc,v 1.18 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/gen/compat___getmntinfo13.c,v 1.1 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/gen/compat_opendir.c,v 1.2 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/sys/Makefile.inc,v 1.10 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/sys/compat___fhstatvfs140.c,v 1.1 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/sys/compat___fhstatvfs40.c,v 1.1 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/sys/compat_fhstatvfs.c,v 1.4 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/sys/compat_fhstatvfs1.c,v 1.4 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/sys/compat_statfs.c,v 1.8 >>> 2019.09.22.22.59.38 christos src/lib/libc/compat/sys/compat_statvfs.c,v 1.1 >>> 2019.09.22.22.59.38 christos src/lib/libc/include/namespace.h,v 1.197 >>> 2019.09.22.22.59.38 christos src/lib/libc/sys/Makefile.inc,v 1.242 >>> 2019.09.22.22.59.38 christos src/lib/libc/sys/statvfs.c,v 1.7 >>> 2019.09.22.22.59.38 christos src/share/man/man5/statvfs.5,v 1.15 >>> 2019.09.22.22.59.38 christos src/sys/compat/common/compat_90_mod.c,v 1.1 >>> 2019.09.22.22.59.38 christos src/sys/compat/common/compat_mod.h,v 1.6 >>> 2019.09.22.22.59.38 christos src/sys/compat/common/files.common,v 1.5 >>> 2019.09.22.22.59.38 christos src/sys/compat/common/vfs_syscalls_20.c,v 1.42 >>> 2019.09.22.22.59.38 christos src/sys/compat/common/vfs_syscalls_30.c,v 1.39 >>> 2019.09.22.22.59.38 christos src/sys/compat/common/vfs_syscalls_90.c,v 1.1 >>> 2019.09.22.22.59.38 christos src/sys/compat/netbsd32/files.netbsd32,v 1.49 >>> 2019.09.22.22.59.38 christos src/sys/compat/netbsd32/netbsd32.h,v 1.124 >>> 2019.09.22.22.59.38 christos src/sys/compat/netbsd32/netbsd32_compat_90.c,v 1.1 >>> 2019.09.22.22.59.38 christos src/sys/compat/netbsd32/netbsd32_conv.h,v 1.39 >>> 2019.09.22.22.59.38 christos src/sys/compat/netbsd32/netbsd32_fs.c,v 1.84 >>> 2019.09.22.22.59.38 christos src/sys/compat/netbsd32/syscalls.conf,v 1.17 >>> 2019.09.22.22.59.38 christos src/sys/compat/netbsd32/syscalls.master,v 1.128 >>> 2019.09.22.22.59.38 christos src/sys/conf/compat_netbsd90.config,v 1.1 >>> 2019.09.22.22.59.38 christos src/sys/conf/files,v 1.1240 >>> 2019.09.22.22.59.39 christos src/sys/kern/init_sysent.c,v 1.324 >>> 2019.09.22.22.59.39 christos src/sys/kern/syscalls.conf,v 1.30 >>> 2019.09.22.22.59.39 christos src/sys/kern/syscalls.master,v 1.296 >>> 2019.09.22.22.59.39 christos src/sys/kern/vfs_subr.c,v 1.472 >>> 2019.09.22.22.59.39 christos src/sys/kern/vfs_syscalls.c,v 1.536 >>> 2019.09.22.22.59.39 christos src/sys/miscfs/specfs/spec_vnops.c,v 1.176 >>> 2019.09.22.22.59.39 christos src/sys/modules/Makefile,v 1.227 >>> 2019.09.22.22.59.39 christos src/sys/modules/compat_90/Makefile,v 1.1 >>> 2019.09.22.22.59.40 christos src/sys/modules/compat_netbsd32_90/Makefile,v 1.1 >>> 2019.09.22.22.59.40 christos src/sys/sys/param.h,v 1.613 >>> 2019.09.22.22.59.40 christos src/sys/sys/statvfs.h,v 1.19 >>> 2019.09.22.22.59.40 christos src/usr.bin/ktruss/dump.c,v 1.44 >>> 2019.09.22.23.03.20 christos src/sys/compat/netbsd32/netbsd32_syscall.h,v 1.143 >>> 2019.09.22.23.03.20 christos src/sys/compat/netbsd32/netbsd32_syscallargs.h,v 1.142 >>> 2019.09.22.23.03.20 christos src/sys/compat/netbsd32/netbsd32_syscalls.c,v 1.142 >>> 2019.09.22.23.03.20 christos src/sys/compat/netbsd32/netbsd32_syscalls_autoload.c,v 1.22 >>> 2019.09.22.23.03.20 christos src/sys/compat/netbsd32/netbsd32_sysent.c,v 1.141 >>> 2019.09.22.23.03.20 christos src/sys/compat/netbsd32/netbsd32_systrace_args.c,v 1.33 >>> 2019.09.22.23.03.20 christos src/sys/kern/init_sysent.c,v 1.325 >>> 2019.09.22.23.03.20 christos src/sys/kern/syscalls.c,v 1.314 >>> 2019.09.22.23.03.20 christos src/sys/kern/syscalls_autoload.c,v 1.31 >>> 2019.09.22.23.03.20 christos src/sys/kern/systrace_args.c,v 1.33 >>> 2019.09.22.23.03.20 christos src/sys/rump/include/rump/rump_syscalls.h,v 1.112 >>> 2019.09.22.23.03.20 christos src/sys/rump/rump.sysmap,v 1.6 >>> 2019.09.22.23.03.21 christos src/sys/rump/librump/rumpkern/rump_syscalls.c,v 1.142 >>> 2019.09.22.23.03.21 christos src/sys/rump/librump/rumpkern/rumpkern_syscalls.c,v 1.5 >>> 2019.09.22.23.03.21 christos src/sys/rump/librump/rumpnet/rumpnet_syscalls.c,v 1.5 >>> 2019.09.22.23.03.21 christos src/sys/rump/librump/rumpvfs/rumpvfs_syscalls.c,v 1.6 >>> 2019.09.22.23.03.21 christos src/sys/sys/syscall.h,v 1.308 >>> 2019.09.22.23.03.21 christos src/sys/sys/syscallargs.h,v 1.292 >>> 2019.09.22.23.13.10 kamil src/sys/sys/cdefs.h,v 1.145 >>> 2019.09.22.23.18.53 christos src/sys/compat/sys/statvfs.h,v 1.1 >>> 2019.09.22.23.23.12 kamil src/sys/sys/cdefs.h,v 1.146 >>> 2019.09.22.23.34.13 kamil src/external/gpl3/gcc/dist/gcc/cppbuiltin.c,v 1.2 >>> >>> Log files can be found at: >>> >>> http://releng.NetBSD.org/b5reports/i386/commits-2019.09.html#2019.09.22.23.34.13 >>> >> >> # compile libsyspuffs/puffs_vfsops.pico >> /tmp/bracket/build/2019.09.22.23.34.13-i386/tools/bin/i486--netbsdelf-gcc -O2 >> -fno-delete-null-pointer-checks -ffreestanding -fno-strict-aliasing >> -msoft-float -mno-mmx -mno-sse -mno-avx -msoft-float -mno-mmx -mno-sse >> -mno-avx -std=gnu99 -Wall -Wstrict-prototypes -Wmissing-prototypes >> -Wpointer-arith -Wno-sign-compare -Wsystem-headers -Wno-traditional >> -Wa,--fatal-warnings -Wreturn-type -Wswitch -Wshadow -Wcast-qual >> -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Werror >> -Wno-format-zero-length -Wno-pointer-sign -fPIE -fstack-protector >> -Wstack-protector --param ssp-buffer-size=1 -DPUFFSDEBUG >> --sysroot=/tmp/bracket/build/2019.09.22.23.34.13-i386/destdir >> -DCOMPAT_50 -DCOMPAT_60 -DCOMPAT_70 -DCOMPAT_80 -nostdinc -imacros >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../include/opt/opt_rumpkernel.h >> -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs >> -I. >> -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../../common/include >> -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../include >> -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../include/opt >> -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../arch >> -I/tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../.. >> -DDIAGNOSTIC -DKTRACE -D_FORTIFY_SOURCE=2 -c -fPIC >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../fs/puffs/puffs_vfsops.c >> -o puffs_vfsops.pico >> In file included from >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../fs/puffs/puffs_vfsops.c:32:0: >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../sys/cdefs.h:169:39: >> error: negative width in bit-field '__ctassert10' >> #define __CTASSERT(x) __CTASSERT0(x, __ctassert, __COUNTER__) >> ^ >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../sys/cdefs.h:178:16: >> note: in definition of macro '__CTASSERT1' >> unsigned int y ## z : /*CONSTCOND*/(x) ? 1 : -1; \ >> ^ >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../sys/cdefs.h:169:24: >> note: in expansion of macro '__CTASSERT0' >> #define __CTASSERT(x) __CTASSERT0(x, __ctassert, __COUNTER__) >> ^~~~~~~~~~~ >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../lib/libkern/libkern.h:254:22: >> note: in expansion of macro '__CTASSERT' >> #define CTASSERT(x) __CTASSERT(x) >> ^~~~~~~~~~ >> /tmp/bracket/build/2019.09.22.23.34.13-i386/src/sys/rump/fs/lib/libsyspuffs/../../../../fs/puffs/puffs_vfsops.c:87:1: >> note: in expansion of macro 'CTASSERT' >> CTASSERT(sizeof(struct puffs_kargs) == 3928); >> ^~~~~~~~ >> >> >> I'm looking into this now. >> > > This change is not related to my modification as it would be caught by > the older __CTASSERT: > > In file included from /usr/src/sys/fs/puffs/puffs_vfsops.c:32:0: > /usr/src/sys/sys/cdefs.h:169:39: error: size of array '__ctassert10' is > negative > #define __CTASSERT(x) __CTASSERT0(x, __ctassert, __COUNTER__) > ^ > /usr/src/sys/sys/cdefs.h:176:43: note: in definition of macro '__CTASSERT1' > #define __CTASSERT1(x, y, z) typedef char y ## z[/*CONSTCOND*/(x) ? 1 : > -1] __unused > ^ > /usr/src/sys/sys/cdefs.h:169:24: note: in expansion of macro '__CTASSERT0' > #define __CTASSERT(x) __CTASSERT0(x, __ctassert, __COUNTER__) > ^~~~~~~~~~~ > /usr/src/sys/lib/libkern/libkern.h:254:22: note: in expansion of macro > '__CTASSERT' > #define CTASSERT(x) __CTASSERT(x) > ^~~~~~~~~~ > /usr/src/sys/fs/puffs/puffs_vfsops.c:87:1: note: in expansion of macro > 'CTASSERT' > CTASSERT(sizeof(struct puffs_kargs) == 3928); > > > The problem is that struct statvfs is used in the puffs protocol in > puffs_kargs (src/sys/fs/puffs/puffs_msgif.h): > > /* > * Try to ensure data structures used by the puffs protocol > * do not unexpectedly change. > */ > #if defined(__i386__) && defined(__ELF__) > CTASSERT(sizeof(struct puffs_kargs) == 3928); > CTASSERT(sizeof(struct vattr) == 136); > CTASSERT(sizeof(struct puffs_req) == 44); > #endif > > This is related to the statvfs size change. > > I don't know how to fix it properly... version the protocol or in the > worst case: revert? > I don't have understanding of the puffs protocols, but pa_svfsb from struct puffs_kargs is not used much except internally.. maybe it would be legitimate to add puffs_statvfs that is equivalent to old statvfs and keep it around in the puffs code. https://nxr.netbsd.org/xref/src/lib/libpuffs/subr.c#puffs_fsnop_statvfs https://nxr.netbsd.org/xref/src/sys/fs/puffs/puffs_vfsops.c#219 It would be dirty, but it might be good enough.
Attachment:
signature.asc
Description: OpenPGP digital signature