Re: panic when removing a file in current

["J. Hannken-Illjes" <hannken%eis.cs.tu-bs.de@localhost>]

On Thu, Jul 19, 2018 at 01:08:22PM +0200, Johnny Billquist wrote:
> Hmm. That means I need to update user land, which can be a bit scary since it can make a rollback really hard.
> And there is also a chicken and egg thing here. Installing a new user land can potentially mean removing files, which will trigger the panic.
> 
> Is it really motivated with that panic? The system is running without issues on that same file system and NetBSD 7.

You could backport this change to -7 fsck_ffs, the patch (attached) is small.

--
J. Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig (Germany)

Index: pass1.c
===================================================================
RCS file: /cvsroot/src/sbin/fsck_ffs/pass1.c,v
retrieving revision 1.57
retrieving revision 1.58
diff -p -u -r1.57 -r1.58
--- pass1.c	8 Feb 2017 16:11:40 -0000	1.57
+++ pass1.c	13 Feb 2018 11:20:08 -0000	1.58
@@ -253,8 +253,9 @@ checkinode(ino_t inumber, struct inodesc
 		    (memcmp(dp->dp1.di_db, ufs1_zino.di_db,
 			UFS_NDADDR * sizeof(int32_t)) ||
 		    memcmp(dp->dp1.di_ib, ufs1_zino.di_ib,
-			UFS_NIADDR * sizeof(int32_t)))) ||
-		    mode || size) {
+			UFS_NIADDR * sizeof(int32_t))))
+		    ||
+		    mode || size || DIP(dp, blocks)) {
 			pfatal("PARTIALLY ALLOCATED INODE I=%llu",
 			    (unsigned long long)inumber);
 			if (reply("CLEAR") == 1) {