Re: pcidevs

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Tue, Jul 03, 2018 at 07:46:43AM -0700, Jason Thorpe wrote:
> I???d list the constant as ???SANDISK???, but the vendor description could be ???Western Digital (Sandisk)???.

Thanks for the suggestion - I just committed it. I'm a little puzzled by
the output:

$ make USETOOLS=no -f Makefile.pcidevs
/bin/rm -f pcidevs.h pcidevs_data.h
awk -f /usr/master/src/sys/dev/pci/../devlist2h.awk pcidevs
Maximum vendor string length:  17
Maximum product string length: 79

Given that strlen("Western Digital (SanDisk)") = 25.

Still, PCI_VENDORSTR_LEN = 64, so there shouldn't be a problem...

Cheers,

Patrick

> -- thorpej
> Sent from my iPhone.
> 
> > On Jul 3, 2018, at 7:33 AM, Patrick Welche <prlw1%cam.ac.uk@localhost> wrote:
> > 
> > I have a
> > 
> > nvme0 at pci4 dev 0 function 0: vendor 15b7 product 5002 (rev. 0x00)
> > 
> > 15b7 according to some lists is "Sandisk Corp.", however:
> > 
> >  "Western Digital welcomes SanDisk to its family of Brands
> > 
> >   SanDisk, a Western Digital Corporation (NASDAQ: WDC) brand, provides
> >   trusted and innovative flash storage products that have transformed the
> >   electronics industry. SanDisk's quality, state-of-the-art solutions are
> >   at the heart of many of the world's largest data centers, and embedded
> >   in advanced smartphones, tablets and PCs. SanDisk's consumer products
> >   are available at hundreds of thousands of retail stores worldwide."
> > 
> > so
> >  vendor WD2 0x15b7 Western Digital
> > or
> >  vendor SANDISK 0x15b7 SanDisk
> > ?
> > 
> > 5002 is a WD Black NVMe SSD
> > 
> > 
> > Cheers,
> > 
> > Patrick