Re: libc++ leakage when building with MKLLVM=yes

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, Dec 23, 2015 at 11:20:19PM +0100, Joerg Sonnenberger wrote:
> On Wed, Dec 23, 2015 at 06:14:18PM +0100, Thomas Klausner wrote:
> > On Wed, Dec 23, 2015 at 11:11:04AM +0100, Thomas Klausner wrote:
> > > While testing MKREPRO builds, by oversight I built one version with
> > > MKLLVM=yes and one without. (I didn't set HAVE_LLVM in either build.)
> > 
> > Henning pointed out to me that libproc's Makefile has a MKLIBCXX
> > conditional inside.
> > 
> > Should this be split in a MKLIBCXX and HAVELIBCXX like for LLVM?
> 
> Just set LIBISCXX.

Do you mean like in the attached diff?
 Thomas

Index: Makefile
===================================================================
RCS file: /cvsroot/src/external/bsd/libproc/lib/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- Makefile	24 Sep 2015 14:12:48 -0000	1.1
+++ Makefile	23 Dec 2015 22:44:57 -0000
@@ -36,11 +36,7 @@
 .if defined(NOCPLUSPLUS)
 CPPFLAGS+=	-DNO_CXA_DEMANGLE
 .else
-. if ${MKLIBCXX} == "yes"
-LIBDPLIBS+=     c++     ${NETBSDSRCDIR}/external/bsd/libc++/lib
-. else
-LIBDPLIBS+=     stdc++  ${NETBSDSRCDIR}/external/gpl3/${EXTERNAL_GCC_SUBDIR}/lib/libstdc++-v3
-. endif
+LIBISCXX=	yes
 .endif
 
 LIBDPLIBS+=	elf ${NETBSDSRCDIR}/external/bsd/elftoolchain/lib/libelf