Re: rump i386 cross compile trouble

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Sat, Mar 07, 2015 at 09:55:08PM +0100, J. Hannken-Illjes wrote:
> On 07 Mar 2015, at 18:03, Patrick Welche <prlw1%cam.ac.uk@localhost> wrote:
> 
> > -               if (modclass != MODULE_CLASS_EXEC || error != ENOENT)
> > +               if ((modclass != MODULE_CLASS_EXEC || error != ENOENT) &&
> > +                   root_device != NULL)
> > 
> > but why? Compiler bug (gcc)?
> 
> Given this fragment is "#ifdef DEBUG" it looks like rump_server has to
> be linked with librumpvfs in the DEBUG case?

Indeed! The attached seems to fix the build - comments?

Cheers,

Patrick

Index: Makefile
===================================================================
RCS file: /cvsroot/src/usr.bin/rump_server/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- Makefile	7 Jan 2015 22:24:03 -0000	1.8
+++ Makefile	9 Mar 2015 11:24:05 -0000
@@ -7,7 +7,13 @@
 SRCS=		rump_allserver.c
 NOMAN=		installed by ../rump_allserver
 
+.include <bsd.own.mk>
+
 LDADD+=		-Wl,--whole-archive -lrumpkern_sysproxy -lrump \
 		-lrumpuser -Wl,--no-whole-archive -lpthread
 
+.ifdef RUMP_DEBUG
+LDADD+=		-lrumpvfs
+.endif
+
 .include <bsd.prog.mk>