Re: HEADS UP: riastradh-drm2 branch merged

[David H.Gutteridge <dhgutteridge%sympatico.ca@localhost>]

On 2014-03-20, at 6:27 PM, David H. Gutteridge wrote:
> On Tue, 18 Mar 2014 at 19:17:01, Taylor R Campbell wrote:
>> I merged the riastradh-drm2 branch to HEAD today.  This shouldn't
>> cause any problems for anyone, because it touched very little outside
>> sys/external/bsd/drm2 -- it's not hooked into any kernels other than
>> the new amd64/DRMKMS one.  But let me know if you observe any fallout.
>> 
>> Update to userland X.org should be coming soon, so that userlands can
>> take advantage of the new DRM/KMS drivers.
> 
> Hello,
> 
> I doubt I'm telling you anything you don't already know, but I tried
> compiling a DRMKMS kernel for both amd64 and i386 to test, and
> neither compiled.
> 
> With amd64, I hit this:
> 
> /usr/builds/netbsd-current/src/sys/external/bsd/drm2/dist/drm/drm_edid.c: In 
> function 'do_cvt_mode':
> /usr/builds/netbsd-current/src/sys/external/bsd/drm2/dist/drm/drm_edid.c:1399:13:
>  error: 'width' may be used uninitialized in this function 
> [-Werror=maybe-uninitialized]
>     newmode = drm_cvt_mode(dev, width, height,
>             ^
> In file included from 
> /usr/builds/netbsd-current/src/sys/external/bsd/drm2/dist/drm/drm_edid.c:30:0:
> /usr/builds/netbsd-current/src/sys/external/bsd/drm2/dist/drm/drm_edid.c:1375:25:
>  note: 'width' was declared here
>   int uninitialized_var(width), height;
>                         ^
> /usr/builds/netbsd-current/src/sys/external/bsd/drm2/include/linux/kernel.h:47:30:
>  note: in definition of macro 'uninitialized_var'
> #define uninitialized_var(x) x
>                              ^
> cc1: all warnings being treated as errors
> *** [drm_edid.o] Error code 1
> 
> I assume this must simply be fallout from GCC being upgraded to 4.8.3.

After the commit referenced below, I'm able to build the amd64 kernel.

Regards,

Dave

Module Name:    src
Committed By:   riastradh
Date:           Fri Mar 21 02:25:05 UTC 2014

Modified Files:
        src/sys/external/bsd/drm2/include/linux: kernel.h

Log Message:
Make uninitialized_var kludge expand to `x = 0'.

Forgot to commit this the other day.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/external/bsd/drm2/include/linux/kernel.h