Re: Build break for evbearm-{6,7}{,hf}-{eb,el} - libc/sync

[Dennis Ferguson <dennis.c.ferguson%gmail.com@localhost>]

On 3 Mar, 2014, at 08:58 , Paul Goyette <paul%whooppee.com@localhost> wrote:
> With sources updated on 2014-03-02 at 00:28:02 UTC (I haven't seen any 
> relevant commits since that time)
> 
> dependall ===> tests/lib/libc/sync
> #      link  sync/all_sync_ops_linkable
> /build/netbsd-local/tools/x86_64/evbearmv6-eb/bin/armv6eb--netbsdelf-eabi-gcc 
>    --sysroot=/build/netbsd-local/dest/evbearmv6-eb     -o 
> all_sync_ops_linkable  all_sync_ops_linkable.o  
> -Wl,-rpath-link,/build/netbsd-local/dest/evbearmv6-eb/lib  -L=/lib 
> all_sync_ops_linkable.o: In function `main':
> all_sync_ops_linkable.c:(.text+0x370): undefined reference to 
> `__sync_sub_and_fetch_8'
> collect2: ld returned 1 exit status

The source file for the function it wants is there but isn't
being built.  The patch below fixed it for me.

Dennis Ferguson

Index: common/lib/libc/arch/arm/atomic/Makefile.inc
===================================================================
RCS file: /cvsroot/src/common/lib/libc/arch/arm/atomic/Makefile.inc,v
retrieving revision 1.19
diff -u -r1.19 Makefile.inc
--- common/lib/libc/arch/arm/atomic/Makefile.inc        27 Feb 2014 09:39:00 
-0000      1.19
+++ common/lib/libc/arch/arm/atomic/Makefile.inc        3 Mar 2014 19:30:11 
-0000
@@ -34,6 +34,7 @@
 .endfor
 SRCS.atomic+=  atomic_dec_32.S atomic_dec_64.S
 SRCS.atomic+=  atomic_inc_32.S atomic_inc_64.S
+SRCS.atomic+=  atomic_sub_64.S
 SRCS.atomic+=  atomic_swap.S atomic_swap_16.S atomic_swap_64.S
 SRCS.atomic+=  membar_ops.S
 .for op in add and nand or sub xor