psshfs atf regression tests are broken?

[Paul Goyette <paul%whooppee.com@localhost>]

Seems that something has recently caused some breakage in the psshfs. 
The test case itself seems to be succeeding (?) but post-test clean-up 
fails?

The atf-report shows this:

fs/psshfs/t_psshfs (115/521): 3 test cases
     inode_nos: atf-run: ERROR: XXX: Cannot get information of 
/tmp/atf-run.00043k/mnt; lstat(2) failed: Device busy [5.880311s] Passed.
atf-report: ERROR: 6167: Unexpected token `<<EOF>>'; expected start of test
atf-report: case
df-post-test Filesystem    1K-blocks       Used      Avail %Cap Mounted on
df-post-test /dev/wd0a       1776966     543028    1145090  32% /
df-post-test kernfs                1          1          0 100% /kern
df-post-test ptyfs                 1          1          0 100% /dev/pts
df-post-test procfs                4          4          0 100% /proc
ps-post-test UID   PID PPID   CPU PRI NI   VSZ  RSS WCHAN   STAT TTY      TIME 
COMMAND
ps-post-test   0     0    0     0 125  0     0 2244 uvm     DKl  ?     0:05.25 
[system]
ps-post-test   0     1    0 16301  82  0 13016 1356 wait    Ss   ?     0:00.35 
init
ps-post-test   0   153    1     0  85  0 23796 1948 kqueue  Is   ?     0:00.22 
/usr/sbin/syslogd -s
ps-post-test   0   282    1     0  85  0 13032 1100 kqueue  Is   ?     0:00.02 
/usr/sbin/powerd
ps-post-test   0   347    1  2981  85  0 15132 1152 kqueue  Is   ?     0:00.02 
/usr/sbin/inetd -l
ps-post-test   0   373    1  1719  85  0 10980 1380 nanoslp Is   ?     0:00.09 
/usr/sbin/cron
ps-post-test   0 18942    1     0   0  0     0    0 -       DEs  ?     0:00.00 
(mount_psshfs)
ps-post-test   0   364    1  1304  85  0 59896 3584 wait    Is   tty00 0:00.36 
login
ps-post-test   0   381  364 22983  82  0 13264 1720 wait    S    tty00 0:00.35 
/bin/sh
ps-post-test   0 26250  381 22983  36  0 13264    4 -       R+   tty00 0:00.00 
/bin/sh
ps-post-test   0 26904  381 22983  32  0 13060 1208 -       O+   tty00 0:00.03 
ps -glaxw
ps-post-test   0   374    1   438  85  0 13040 1392 ttyraw  Is+  ttyE1 0:00.05 
/usr/libexec/getty Pc ttyE1
ps-post-test   0   368    1   189  85  0 13040 1392 ttyraw  Is+  ttyE2 0:00.03 
/usr/libexec/getty Pc ttyE2
ps-post-test   0   372    1   189  85  0 13040 1392 ttyraw  Is+  ttyE3 0:00.04 
/usr/libexec/getty Pc ttyE3
anita-root-shell# echo $?
echo $?
1
anita-root-shell#


And the raw output from atf-run contains this:

tp-start: 1342868516.471131, fs/psshfs/t_psshfs, 3
tc-start: 1342868516.474134, inode_nos
tc-so:Setting up SSH server configuration
tc-so:Executing command [ cp /usr/libexec/sftp-server . ]
tc-so:Executing command [ cp /usr/tests/fs/psshfs/ssh_host_key . ]
tc-so:Executing command [ cp /usr/tests/fs/psshfs/ssh_host_key.pub . ]
tc-so:Executing command [ chmod 400 ssh_host_key ]
tc-so:Executing command [ chmod 444 ssh_host_key.pub ]
tc-so:SSH server started (pid 26218)
tc-so:Setting up SSH client configuration
tc-so:Executing command [ ssh-keygen -f ssh_user_key -t rsa -b 1024 -N  -q ]
tc-so:Executing command [ cp ssh_user_key.pub authorized_keys ]
tc-so:Executing command [ chmod 600 authorized_keys ]
tc-so:Executing command [ mount -t psshfs -o -F=/tmp/atf-run.00043k/ssh_config 
localhost:/tmp/atf-run.00043k/root mnt ]
tc-so:Executing command [ ./ne_inodes.sh root/dir root/dir/file1 ]
tc-so:Executing command [ ./ne_inodes.sh root/dir root/dir/file2 ]
tc-so:Executing command [ ./ne_inodes.sh root/dir/file1 root/dir/file2 ]
tc-so:Executing command [ ./ne_inodes.sh root/file3 root/file4 ]
tc-se:umount: mnt: not currently mounted
tc-so:Stopping SSH server (pid 26218)
tc-so:Server output was:
tc-end: 1342868522.354445, inode_nos, passed


This problem started with commits that occurred on 2012-07-21 between 
01:20:07 and 06:50:07 UTC, and still exists with sources checked out at 
20:50:07.

P lib/libperfuse/debug.c
P lib/libperfuse/ops.c
P lib/libperfuse/perfuse.c
P lib/libperfuse/perfuse_if.h
P lib/libperfuse/perfuse_priv.h
P lib/libperfuse/subr.c
P lib/libpuffs/dispatcher.c
P lib/libpuffs/puffs.h
P sys/arch/arm/marvell/kirkwoodreg.h
P sys/arch/arm/marvell/mvsoc.c
P sys/dev/marvell/gttwsi.c
P sys/dev/marvell/gttwsireg.h
P sys/fs/puffs/puffs_msgif.c
P sys/fs/puffs/puffs_msgif.h
P sys/fs/puffs/puffs_sys.h
P sys/fs/puffs/puffs_vfsops.c
P sys/fs/puffs/puffs_vnops.c
P usr.sbin/perfused/msg.c
P usr.sbin/perfused/perfused.c



-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------