Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Filesystem tests crashing host

On Sat, 16 Apr 2011, Andreas Gustafsson wrote:

Jukka Ruohonen wrote:
On Thu, Apr 14, 2011 at 06:27:19AM -0700, Paul Goyette wrote:
The fault is coming from the following code at lines 817-821 of
src/sys/kern/kern_descrip.c (rev. 1.212, in which christos@ touched the
close-on-exec stuff)

        if (fp->f_ops != NULL) {
                error = (*fp->f_ops->fo_close)(fp);
        } else {
                error = 0;

Now that this is diagnosed, any idea how to fix this regression that
broke the whole test infrastructure?

I still say revert rmind's changes of 2011., because
that's when the failures started.  My logs show six test runs between
christos' change to kern_descrip.c (at 2011. and rmind's
changes, and none of those test runs paniced; after rmind's changes,
every single test run has paniced.

Just one more data point:

I was completely unable to reproduce this by simply starting up the qemu machine and running either

   or   atf-test | atf-report

The only time I was able to reproduce it was when I used the more complicated pipeline that anita uses:

        atf-run | tee /tmp/X | atf-report -o ticker:- -o xml:/tmp/Y

Not sure why it makes a difference.

| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index