Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: getaddrinfo tests

On Fri Feb 04 2011 at 09:22:38 +0100, Martin Husemann wrote:
> On Fri, Feb 04, 2011 at 08:13:54AM +0900, Takahiro HAYASHI wrote:
> > i think lib/libc/net/getifaddrs.c needs fixed.
> > should use RT_ROUNDUP macro in <net/route.h>?

Yup, it appears to be fixed now.  Thanks!

(and thanks to Paul Goyette, who added the test to the atf tree and
allowed us to catch this platform-dependent regression quickly)

> Good catch, and it should, indeed.
> We should check if there are other variants of this hidden over the tree
> and make them all use RT_ROUNDUP.

The in-tree ones are "easy", but are there non-zero out-of-tree ones?

älä karot toivorikkauttas, kyl rätei ja lumpui piisaa

Home | Main Index | Thread Index | Old Index