Re: named not starting

[Shin'ichiro TAYA <taya%ba2.so-net.ne.jp@localhost>]

(10/12/23 7:16), Christos Zoulas wrote:
> In article<20101222210140.4fc1e682.tnn%NetBSD.org@localhost>,
> Tobias Nygren<tnn%NetBSD.org@localhost>  wrote:
>> On Fri, 17 Dec 2010 13:06:16 +1300
>> Mark Davies<mark%ecs.vuw.ac.nz@localhost>  wrote:
>>
>>> Updating to a -current/i386 from this morning, named no longer starts:
>> [...]
>>> Dec 17 11:51:44 atlanta named[215]: exiting (due to assertion
>> failure)
>>>
>>> was working with a current from 2 weeks ago.
>>
>> Same here. Rebuilding with NAMED_USE_PTHREADS=no seems to make it start.
>> 5.99.41 from 20101218 on amd64.
> 
> I cannot reproduce it on i386 or amd64...

There are two bugs in following places.
First one cause ISC_NO_ATOMIC defined and enables the codes which have
second one.

--- include/isc/atomic.h        14 Dec 2010 23:19:23 -0000      1.2
+++ include/isc/atomic.h        25 Dec 2010 14:28:18 -0000
@@ -3,7 +3,7 @@
 #ifndef ISC_ATOMIC_H
 #define ISC_ATOMIC_H 1

-#ifdef ISC_PLATFORM_USE_THREADS
+#ifdef ISC_PLATFORM_USETHREADS
 #include <sys/atomic.h>
 #else
 #define ISC_NO_ATOMIC
@@ -61,7 +61,7 @@
 isc_atomic_cmpxchg(isc_int32_t *p, isc_int32_t cmpval, isc_int32_t val) {
 #ifdef ISC_NO_ATOMIC
        isc_int32_t oval = *p;
-       if (oval == val)
+       if (oval == cmpval)
                *p = val;
        return oval;
 #else