Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: paddr_t change to 64-bits



jeanyves.migeon%free.fr@localhost said:
> IMHO, the ioctl should be versioned; however, how am I supposed to do
> so? Define AGPIOC_ALLOCATE2, and patch the drm code to use it?

This doesn't make sense. The agp code is mostly limited
to 32-bit addresses (GATT entries etc), you'd need range
checks everywhere an implicite truncation happens.

As has been said elsewhere, a change of paddr_t width
causes more problems that it solves, and makes an impression
of poor engineering. Better fix abuses of paddr_t in
interfaces relevant to LKMs.

best regards
Matthias



------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDirig Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------


Home | Main Index | Thread Index | Old Index