Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: compile librump/compat.o failed on amd64



On Sat, Jul 24, 2010 at 17:16:32 +0200, Nicolas Joly wrote:

> +#ifdef __x86_64__
> +
[... ~100 lines of source code ...]
>  
>  #include <x86/pte.h>
>  
> +#else   /*      __x86_64__      */
> +
> +#include <i386/pte.h>
> +
> +#endif  /*      __x86_64__      */

Just a nit, but please, don't just repeat the ifdef condition on #else
like that, properly invert it to reflect when the #else part is used.

-uwe


Home | Main Index | Thread Index | Old Index