Re: NetBSD-5 build broken in libudf

[Iain Hibbert <plunky%rya-online.net@localhost>]

On Wed, 18 Feb 2009, Iain Hibbert wrote:

> Hi,
>    NetBSD-5 build is broken today at:
>
> #   compile  libudf/udf_subr.o
> /usr/tools/bin/i386--netbsdelf-gcc -O2 -Wno-pointer-sign -DDEBUG -DDIAGNOSTIC 
> -ffreestanding -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
> -Wno-sign-compare -Wno-traditional -Wa,--fatal-warnings -Wreturn-type 
> -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter 
> -std=gnu99  -Werror   
> -I/home/plunky/src/sys/rump/fs/lib/libudf/../../../include  -D_KERNEL 
> -D_RUMPKERNEL -DMULTIPROCESSOR -DDIAGNOSTIC 
> -I/home/plunky/src/sys/rump/fs/lib/libudf -I. 
> -I/home/plunky/src/sys/rump/fs/lib/libudf/../../../../../common/include 
> -nostdinc -I/home/plunky/src/sys/rump/fs/lib/libudf/../../../..   -nostdinc 
> -isystem /var/obj/destdir.i386/usr/include -c    
> /home/plunky/src/sys/rump/fs/lib/libudf/../../../../fs/udf/udf_subr.c -o 
> udf_subr.o
> cc1: warnings being treated as errors
> /home/plunky/src/sys/rump/fs/lib/libudf/../../../../fs/udf/udf_subr.c: In 
> function 'udf_dump_trackinfo':
> /home/plunky/src/sys/rump/fs/lib/libudf/../../../../fs/udf/udf_subr.c:169: 
> warning: implicit declaration of function 'snprintb'
>
>
> I guess this is related to the UDF pullup (#447) as of yesterday..?

I think the correct fix (on NetBSD-5 branch) is below.

iain

--- /usr/src/sys/fs/udf/udf_subr.c      2009-02-18 09:06:23.000000000 +0000
+++ udf_subr.c  2009-02-18 15:53:05.000000000 +0000
@@ -166,7 +166,7 @@ udf_dump_trackinfo(struct mmc_trackinfo
        printf("\tsessionnr           %d\n", trackinfo->sessionnr);
        printf("\ttrack mode          %d\n", trackinfo->track_mode);
        printf("\tdata mode           %d\n", trackinfo->data_mode);
-       snprintb(bits, sizeof(bits), MMC_TRACKINFO_FLAGBITS, trackinfo->flags);
+       bitmask_snprintf(trackinfo->flags, MMC_TRACKINFO_FLAGBITS, bits, 
sizeof(bits));
        printf("\tflags               %s\n", bits);

        printf("\ttrack start         %d\n", trackinfo->track_start);