Re: [PATCH] cleaning ifwatchd

[Roy Marples <roy%marples.name@localhost>]

On Fri, 2008-09-05 at 11:01 +0200, Martin Husemann wrote:
> On Fri, Sep 05, 2008 at 09:51:11AM +0100, Roy Marples wrote:
> > ifwatchd.c:206: warning: ISO C does not support the '%m' printf format
> 
> This warning is wrong, isn't it?

%m is a glibc extension.
http://www.opengroup.org/onlinepubs/000095399/functions/printf.html
And the NetBSD man page for printf do not document %m.

> 
> > The attached patch cleans up all these.
> > Hunks #5 and #6 deal with a subsequent error of vfork potentially
> > clobbering the ifname variable.
> 
> I'm not sure I understand this part - how could the execl() call clobber
> ifname?

I don't know either. I would guess it's a gcc error as there's no real
difference between char[N] and char * when passed to a function.

Thanks

Roy