On Thu, Feb 28, 2008 at 10:04:59AM +0200, Alan Barrett wrote: > On Wed, 27 Feb 2008, Anthony Martinez wrote: > > > init.c is created by mkinit.sh. It appears that init.c is wrong. > > > What host shell are you using (the "HOST_SH" line printed by build.sh > > > > /bin/sh, which appears to be dash. I'll try again with HOST_SH=bash... > > And that seems to have fixed it! > > Could you post a diff between the correct and incorrect versions of > init.c? I'd be interested to see what dash is doing differently, and > figuring out whether the bug is in mkinit.sh or in dash. (I think it's > more likely to be a dash bug.) The unified diff is attached for preservation, though it really is just one line. The version of dash I'm using, by the by, is 0.5.4-1ubuntu3 -- Pi > --apb (Alan Barrett) > -- So like these two strings walk into a bar. One goes to the bartender... "i'd like a jack and cokeEWdc#@@$@23Dwqxsa.xq. qwqw0xx32" The second one says, "you'll have to excuse my friend, he isn't null terminated." <h3n> but the first one wan't really a c string. because null termination is part of the definition. i guess you could say two pointers to char walked into a bar.
--- ../init.c_dash 2008-02-28 01:24:47.000000000 -0700
+++ ../init.c_bash 2008-02-28 01:18:04.000000000 -0700
@@ -223,6 +223,7 @@
ckfree(memout.buf);
memout.buf = NULL;
}
+ }
}
Attachment:
pgpa3oHUstROI.pgp
Description: PGP signature