Subject: Re: M2 assertion with today's current
To: None <current-users@NetBSD.org>
From: Tobias Nygren <tnn@NetBSD.org>
List: current-users
Date: 01/31/2008 08:56:07
On Thu, 31 Jan 2008 01:13:41 +0000
"Mindaugas R." <rmind@NetBSD.org> wrote:
> Matthias Drochner <M.Drochner@fz-juelich.de> wrote:
> > OK, that one is solved: the address calculation in sched_cpuattach()
> > of sched_m2 didn't work as expected. It uses the roundup()
> > macro with a signed argument which leads to unexpected results
> > for addresses >2G.
> > Since CACHE_LINE_SIZE is a power-of-two roundup() is too expensive
> > here anyway -- something doing simple bitmasks would be better,
> > but for not this one fixes it:
>
> Good catch! We have roundup2() which works with power of two values.
> Commited.
Thanks, it fixed my original problem too.
-T