Subject: Re: sys/dev/scsipi/scsipi_base.c
To: John Nemeth <jnemeth@victoria.tc.ca>
From: Adam Hamsik <haaaad@gmail.com>
List: current-users
Date: 01/06/2008 16:57:05
On Jan,Sunday 6 2008, at 12:11 PM, John Nemeth wrote:
> On May 29, 5:30am, David Laight wrote:
> } On Sun, Jan 06, 2008 at 03:41:49AM -0700, John R. Shannon wrote:
> } > Line 1124 has:
> } >
> } > memcpy(inqbuf->vendor, "ADAPTEC ACB-4000 ", 28);
> } >
> } > and line 1144 has:
> } >
> } > memcpy(inqbuf->vendor, "EMULEX MT-02 QIC ", 28);
IMO we should replace this with per-entry memcpy calls.
We can keep that vendor string in another struct
struct vendor{
char vendor[8];
char product[16];
char revision[4];
};
and staticaly set it to "EMULEX MT-02 QIC". I don't that there can be
any performance issues with more memcpy calls.
Regards
Adam.