Subject: Re: crash from ohci detach
To: Christos Zoulas <christos@astron.com>
From: Steven M. Bellovin <smb@cs.columbia.edu>
List: current-users
Date: 01/04/2008 03:10:54
On Fri, 4 Jan 2008 02:47:50 +0000 (UTC)
christos@astron.com (Christos Zoulas) wrote:
> >
> >That said, I think the attached patches should be committed
> >nevertheless. Comments?
>
> Yes, if we call pmf_register we should also call pmf_deregister.
>
My primary concern is the location of the call. Since the pmf_register
calls were at the end of the attach sequence, I put the pmf_deregister
calls at the beginning of the detach sequence. But what happens if
there's a suspend event in the middle of either sequence?
--Steve Bellovin, http://www.cs.columbia.edu/~smb