Subject: Re: Cosmetic issue during probe of acpitz
To: Jared D. McNeill <jmcneill@invisible.ca>
From: Paul Goyette <paul@whooppee.com>
List: current-users
Date: 12/07/2007 12:13:47
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-383750991-1197058427=:23860
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed

With Jared's patch, I get the following dmesg output:

...
FAN (PNP0C0B) at acpi0 not configured 
acpitz0 at acpi0 (THRM): active cooling level 0: 122.0C critical 124.0C passive
40.0C
pcppi0: attached to attimer0
...


I worked on my own patch, which generates the following

...
FAN (PNP0C0B) at acpi0 not configured 
acpitz0 at acpi0 (THRM): unable to get polling interval; using default of 30.0s
acpitz0: : active cooling level 0: 122.0C critical 124.0C passive 40.0C
pcppi0: attached to attimer0
...

I'm not sure which one is better, but they're both cosmetically 
acceptable!  :)

Both patches are attached.

On Fri, 7 Dec 2007, Jared D. McNeill wrote:

> On Fri, 7 Dec 2007, Paul Goyette wrote:
>> Note that the 'unable to get polling interval' line is printed in the 
>> middle of the expected probe line.  Not a big deal.  I can work on a fix if 
>> anyone else thinks it's worthwhile, or I can live with it the way it is.
>
> Please try the following patch.
>
> Cheers,
> Jared
>
> Index: acpi_tz.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/acpi/acpi_tz.c,v
> retrieving revision 1.29
> diff -u -r1.29 acpi_tz.c
> --- acpi_tz.c	2 Dec 2007 06:26:40 -0000	1.29
> +++ acpi_tz.c	7 Dec 2007 19:08:55 -0000
> @@ -169,15 +169,13 @@
> 	aprint_naive("\n");
>
> 	rv = acpi_eval_integer(sc->sc_devnode->ad_handle, "_TZP", &v);
> -	if (ACPI_FAILURE(rv)) {
> -		aprint_verbose("%s: unable to get polling interval; using 
> default of",
> -		    sc->sc_dev.dv_xname);
> +	if (ACPI_FAILURE(rv))
> 		sc->sc_zone.tzp = ATZ_TZP_RATE;
> -	} else {
> +	else
> 		sc->sc_zone.tzp = v;
> -		aprint_verbose("%s: polling interval is", 
> sc->sc_dev.dv_xname);
> -	}
> -	aprint_verbose(" %d.%ds\n", sc->sc_zone.tzp / 10, sc->sc_zone.tzp % 
> 10);
> +
> +	aprint_debug(" sample rate %d.%ds\n",
> +	    sc->sc_zone.tzp / 10, sc->sc_zone.tzp % 10);
>
> 	/* XXX a value of 0 means "polling is not necessary" */
> 	if (sc->sc_zone.tzp == 0)
>

----------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul@whooppee.com   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette@juniper.net |
----------------------------------------------------------------------
--0-383750991-1197058427=:23860
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=acpi_tz.c.patch_jm
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.64.0712071213470.23860@quicky.whooppee.com>
Content-Description: 
Content-Disposition: attachment; filename=acpi_tz.c.patch_jm

SW5kZXg6IGFjcGlfdHouYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT
IGZpbGU6IC9jdnNyb290L3NyYy9zeXMvZGV2L2FjcGkvYWNwaV90ei5jLHYN
CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMA0KZGlmZiAtdSAtcCAtcjEuMzAg
YWNwaV90ei5jDQotLS0gYWNwaV90ei5jCTUgRGVjIDIwMDcgMDc6MDY6NTEg
LTAwMDAJMS4zMA0KKysrIGFjcGlfdHouYwk3IERlYyAyMDA3IDE5OjUzOjM0
IC0wMDAwDQpAQCAtMTY5LDE1ICsxNjksMTMgQEAgYWNwaXR6X2F0dGFjaChz
dHJ1Y3QgZGV2aWNlICpwYXJlbnQsIHN0cg0KIAlhcHJpbnRfbmFpdmUoIlxu
Iik7DQogDQogCXJ2ID0gYWNwaV9ldmFsX2ludGVnZXIoc2MtPnNjX2Rldm5v
ZGUtPmFkX2hhbmRsZSwgIl9UWlAiLCAmdik7DQotCWlmIChBQ1BJX0ZBSUxV
UkUocnYpKSB7DQotCQlhcHJpbnRfdmVyYm9zZSgiJXM6IHVuYWJsZSB0byBn
ZXQgcG9sbGluZyBpbnRlcnZhbDsgdXNpbmcgZGVmYXVsdCBvZiIsDQotCQkg
ICAgc2MtPnNjX2Rldi5kdl94bmFtZSk7DQorCWlmIChBQ1BJX0ZBSUxVUkUo
cnYpKQ0KIAkJc2MtPnNjX3pvbmUudHpwID0gQVRaX1RaUF9SQVRFOw0KLQl9
IGVsc2Ugew0KKwllbHNlDQogCQlzYy0+c2Nfem9uZS50enAgPSB2Ow0KLQkJ
YXByaW50X3ZlcmJvc2UoIiVzOiBwb2xsaW5nIGludGVydmFsIGlzIiwgc2Mt
PnNjX2Rldi5kdl94bmFtZSk7DQotCX0NCi0JYXByaW50X3ZlcmJvc2UoIiAl
ZC4lZHNcbiIsIHNjLT5zY196b25lLnR6cCAvIDEwLCBzYy0+c2Nfem9uZS50
enAgJSAxMCk7DQorDQorCWFwcmludF9kZWJ1ZygiIHNhbXBsZSByYXRlICVk
LiVkc1xuIiwNCisJICAgIHNjLT5zY196b25lLnR6cCAvIDEwLCBzYy0+c2Nf
em9uZS50enAgJSAxMCk7DQogDQogCS8qIFhYWCBhIHZhbHVlIG9mIDAgbWVh
bnMgInBvbGxpbmcgaXMgbm90IG5lY2Vzc2FyeSIgKi8NCiAJaWYgKHNjLT5z
Y196b25lLnR6cCA9PSAwKQ0K

--0-383750991-1197058427=:23860
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=acpi_tz.c.patch_pg
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.64.0712071213471.23860@quicky.whooppee.com>
Content-Description: 
Content-Disposition: attachment; filename=acpi_tz.c.patch_pg

SW5kZXg6IGFjcGlfdHouYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT
IGZpbGU6IC9jdnNyb290L3NyYy9zeXMvZGV2L2FjcGkvYWNwaV90ei5jLHYN
CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMA0KZGlmZiAtdSAtcCAtcjEuMzAg
YWNwaV90ei5jDQotLS0gYWNwaV90ei5jCTUgRGVjIDIwMDcgMDc6MDY6NTEg
LTAwMDAJMS4zMA0KKysrIGFjcGlfdHouYwk3IERlYyAyMDA3IDE5OjM0OjU1
IC0wMDAwDQpAQCAtMTcwLDE0ICsxNzAsMTQgQEAgYWNwaXR6X2F0dGFjaChz
dHJ1Y3QgZGV2aWNlICpwYXJlbnQsIHN0cg0KIA0KIAlydiA9IGFjcGlfZXZh
bF9pbnRlZ2VyKHNjLT5zY19kZXZub2RlLT5hZF9oYW5kbGUsICJfVFpQIiwg
JnYpOw0KIAlpZiAoQUNQSV9GQUlMVVJFKHJ2KSkgew0KLQkJYXByaW50X3Zl
cmJvc2UoIiVzOiB1bmFibGUgdG8gZ2V0IHBvbGxpbmcgaW50ZXJ2YWw7IHVz
aW5nIGRlZmF1bHQgb2YiLA0KLQkJICAgIHNjLT5zY19kZXYuZHZfeG5hbWUp
Ow0KKwkJYXByaW50X3ZlcmJvc2UoIjogdW5hYmxlIHRvIGdldCBwb2xsaW5n
IGludGVydmFsOyB1c2luZyBkZWZhdWx0IG9mIik7DQogCQlzYy0+c2Nfem9u
ZS50enAgPSBBVFpfVFpQX1JBVEU7DQogCX0gZWxzZSB7DQogCQlzYy0+c2Nf
em9uZS50enAgPSB2Ow0KLQkJYXByaW50X3ZlcmJvc2UoIiVzOiBwb2xsaW5n
IGludGVydmFsIGlzIiwgc2MtPnNjX2Rldi5kdl94bmFtZSk7DQorCQlhcHJp
bnRfdmVyYm9zZSgicG9sbGluZyBpbnRlcnZhbCBpcyIpOw0KIAl9DQotCWFw
cmludF92ZXJib3NlKCIgJWQuJWRzXG4iLCBzYy0+c2Nfem9uZS50enAgLyAx
MCwgc2MtPnNjX3pvbmUudHpwICUgMTApOw0KKwlhcHJpbnRfdmVyYm9zZSgi
ICVkLiVkc1xuJXM6ICIsIHNjLT5zY196b25lLnR6cCAvIDEwLA0KKwkgICAg
c2MtPnNjX3pvbmUudHpwICUgMTAsIHNjLT5zY19kZXYuZHZfeG5hbWUpOw0K
IA0KIAkvKiBYWFggYSB2YWx1ZSBvZiAwIG1lYW5zICJwb2xsaW5nIGlzIG5v
dCBuZWNlc3NhcnkiICovDQogCWlmIChzYy0+c2Nfem9uZS50enAgPT0gMCkN
Cg==

--0-383750991-1197058427=:23860--