Subject: Re: savecore -c crashes kernel (-current on i386)
To: Juergen Hannken-Illjes <hannken@eis.cs.tu-bs.de>
From: Markus W Kilbinger <mk@kilbi.de>
List: current-users
Date: 10/08/2007 10:25:31
>>>>> "Juergen" == Juergen Hannken-Illjes <hannken@eis.cs.tu-bs.de> writes:

    Juergen> This buffer dosn't look ok. Could you try this diff:

    Juergen> Index: vfs_trans.c
    Juergen> ===================================================================
    Juergen> RCS file: /cvsroot/src/sys/kern/vfs_trans.c,v retrieving
    Juergen> revision 1.13 diff -p -u -4 -r1.13 vfs_trans.c
    Juergen> --- vfs_trans.c 7 Oct 2007 14:48:38 -0000 1.13
    Juergen> +++ vfs_trans.c 8 Oct 2007 07:55:42 -0000
    Juergen> @@ -592,8 +592,10 @@ fscow_run(struct buf *bp)
    Juergen>  	if (bp->b_vp->v_type == VBLK)
    Juergen>  		mp = bp->b_vp->v_specmountpoint;
    Juergen>  	else
    Juergen>  		mp = bp->b_vp->v_mount;
    Juergen> + if (mp == NULL)
    Juergen> + return 0;
 
    Juergen>  	if ((cmi = mount_getspecific(mp, mount_cow_key)) ==
    Juergen>  	NULL)
    Juergen>  		return 0;
 
Looks good, no crash so far, and swapping is working (again).
Anything I {sh,c}ould stress test?

Thanks, Markus.