Subject: Re: today's commit to wskbd.c/wsksymvar.h
To: Elad Efrat <elad@bsd.org.il>
From: Mike M. Volokhov <mishka@netbsd.org>
List: current-users
Date: 04/04/2007 15:32:04
Elad Efrat <elad@bsd.org.il> wrote:
> essen@dev-extend.eu wrote:
> >> This has broken my keyboard; a while after bootup,  my delete key
> >> stops working (I have to use control-H), and pressing certain
> >> [ordinary] key combinations (that I don't recall) invoked the
> >> debugger.  Reverting to the previous revisions fixed the problem.
> >>
> >> Has anyone else experienced this?
> > 
> > Yes, my delete key stopped working too. I didn't fall into the debugger though.
> > 
> 
> I did.

Elad, could you post more details here? The changes wasn't so intrusive
to gain kernel panic.

> this patch went for public review on 2007-03-29 and received not even
> one "okay" (or comments, for that matter), and was still committed to
> the kernel by a member of the www team less than a week later.
> 
> I'm cc'ing the netbsd core group so that the public can hear more about
> how things like this happen, and what is planned to ensure that at least
> in the long term netbsd's code base does not become a big pile of
> youknowwhatux.

The patch was reverted. Next patch will be submitted as PR. Please
feel free to add any limitations and set exact timeouts in the
Commit Guidelines[1] to handle further problems.

--
Mishka.

[1] http://www.NetBSD.org/developers/commit-guidelines.html