Subject: Re: Another build failure in libpthread
To: None <current-users@netbsd.org>
From: Paul Goyette <paul@whooppee.com>
List: current-users
Date: 01/22/2007 06:21:20
BTW, it is not enough here just to make the variable 'olduc' volatile. 
I tried this, and while it avoids the specific error (ie, 'might be 
clobbered'), it results in "discards attribute" error when passing 
&olduc->uc_sigmask to __sigdelset14() at line 967.

All of the libpthread stuff seems to have been a result of recent 
changes to src/sys/lib/libpthread/arch/i386/_getsetc.s


On Sat, 20 Jan 2007, Paul Goyette wrote:

> This is after the earlier update to pthread_run.c and once again, this 
> happens only for i386;  amd64 builds successfully.
>
> #   compile  libpthread/pthread_sig.o
> /usr/obj/tools.x86_64.i386/bin/i386--netbsdelf-gcc -O2 -Wall 
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare 
> -Wno-traditional -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings 
> -Wextra -Wno-unused-parameter -std=gnu99 -Werror   -Wno-cast-qual 
> -I/usr/src/lib/libpthread/arch/i386 -I/usr/src/lib/libpthread 
> -I/usr/obj/lib/libpthread -D_LIBC -D__LIBPTHREAD_SOURCE__ -DPTHREAD_SA 
> -DPTHREAD_MLOCK_KLUDGE -I/usr/src/sys -I/usr/src/lib/libpthread/../libc 
> -nostdinc -isystem /usr/obj/destdir.i386/usr/include -c 
> /usr/src/lib/libpthread/pthread_sig.c
> -o pthread_sig.o
> cc1: warnings being treated as errors
> /usr/src/lib/libpthread/pthread_sig.c: In function 'pthread__deliver_signal':
> /usr/src/lib/libpthread/pthread_sig.c:943: warning: variable 'olduc' might be 
> clobbered by 'longjmp' or 'vfork'
>
>
> ----------------------------------------------------------------------
> |   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
> | Network Engineer | FA29 0E3B 35AF E8AE 6651 |  paul@whooppee.com   |
> |                  | 0786 F758 55DE 53BA 7731 | pgoyette@juniper.net |
> ----------------------------------------------------------------------
>

----------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
| Network Engineer | FA29 0E3B 35AF E8AE 6651 |  paul@whooppee.com   |
|                  | 0786 F758 55DE 53BA 7731 | pgoyette@juniper.net |
----------------------------------------------------------------------