On Fri, 13 Oct 2006 16:25:10 +0200, Juan RP <juan@xtrarom.org> wrote:

> On Fri, 13 Oct 2006 10:11:37 -0400
> "Steven M. Bellovin" <smb@cs.columbia.edu> wrote:
> 
> > This morning, I tried compiling a locally-written network driver and
> > got an error, despite not having touched the code in a long time:
> > 
> > /usr/src/sys/net/if_null.c: In function 'ifnullattach':
> > /usr/src/sys/net/if_null.c:113: warning: unused parameter 'count'
> > 
> > The code says
> > 
> > 	/* ARGSUSED */
> > 	void
> > 	ifnullattach(count)
> > 	        int count;
> > 	{
> >  	       LIST_INIT(&null_softc_list);
> >         	if_clone_attach(&null_cloner);
> > 	}
> > 
> > It seems that /* ARGSUSED */ is no longer being honored here.  What
> > is the proper way to handle this now, and why was the change made?
> 
> Christos enabled -Wunused for i386.
> 
> Try changing ifnullattach(int count) to ifnullattach(int count
> __unused).
> 
Ah, yes, I see the change in some CVS logs.  (I had bad connectivity at
the time I sent that note.)

Thanks.

		--Steven M. Bellovin, http://www.cs.columbia.edu/~smb