Subject: Re: lfs problem (after ~ 6th Sep)
To: Kouichirou Hiratsuka <hira@po6.nsk.ne.jp>
From: Geoff Wing <gcw@pobox.com>
List: current-users
Date: 09/12/2006 13:19:57
On Monday 2006-09-11 21:58 +0900, Kouichirou Hiratsuka output:
:At Mon, 11 Sep 2006 14:58:12 +0200,
:Elad Efrat wrote:
:> can you try backing out sys/miscfs/specfs/spec_vnops.c and see if it
:> persists?
:
:I tried revision 1.88 of it with today's -current.
:However, the problem still happens.

Good clue.  Thanks for pinpointing the commit.  Reverting only
vfs_syscalls.c to 1.267 works.

Ah, found it.  The change in dofhopen() was misdone and was
causing dofhopen() to always abort early.

Regards.
Geoff

--- sys/kern/vfs_syscalls.c.org	2006-09-09 18:50:38.000000000 +1000
+++ sys/kern/vfs_syscalls.c	2006-09-12 13:10:26.000000000 +1000
@@ -1495,8 +1495,8 @@
 	/*
 	 * Must be super user
 	 */
-	error = kauth_authorize_system(l->l_cred, KAUTH_SYSTEM_FILEHANDLE,
-	    0, NULL, NULL, NULL);
+	if ((error = kauth_authorize_system(l->l_cred, KAUTH_SYSTEM_FILEHANDLE,
+	    0, NULL, NULL, NULL)) != KAUTH_RESULT_ALLOW)
 		return (error);
 
 	flags = FFLAGS(oflags);