Subject: Re: current evbarm/HDL_G kernel build fails in sys/dev/dmover/dmover_io.c
To: Andrew Doran <ad@NetBSD.org>
From: Akihiko HAYASHI <hayashi@totalware.gifu.gifu.jp>
List: current-users
Date: 07/29/2006 14:17:18
Andrew Doran wrote:
> Hi,
> 
> On Fri, Jul 28, 2006 at 07:39:23AM +0900, Akihiko HAYASHI wrote:
> 
>> /home/hayashi/netbsd/src/sys/dev/dmover/dmover_io.c: In function 'dmoverioopen':
>> /home/hayashi/netbsd/src/sys/dev/dmover/dmover_io.c:753: warning: passing argument 1 of 'falloc' from incompatible pointer type
> 
> Sorry about that. This should be fixed by revision 1.23 of dmover_io.c.
> 
> Andrew
> 
> Index: dmover_io.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/dmover/dmover_io.c,v
> retrieving revision 1.22
> diff -u -r1.22 dmover_io.c
> --- dmover_io.c	14 May 2006 21:42:27 -0000	1.22
> +++ dmover_io.c	28 Jul 2006 08:50:47 -0000
> @@ -747,10 +747,9 @@
>  	struct dmio_state *ds;
>  	struct file *fp;
>  	int error, fd, s;
> -	struct proc *p = l->l_proc;
>  
>  	/* falloc() will use the descriptor for us. */
> -	if ((error = falloc(p, &fp, &fd)) != 0)
> +	if ((error = falloc(l, &fp, &fd)) != 0)
>  		return (error);
>  
>  	s = splsoftclock();

Thanks, fixed.