Subject: Re: systm.h's 'version' shadowed in iavc.c (ISDN)
To: Martin Husemann <martin@duskware.de>
From: Hubert Feyrer <hubert@feyrer.de>
List: current-users
Date: 07/09/2005 01:27:24
On Sat, 9 Jul 2005, Martin Husemann wrote:
> Rename the variable in that function (to "ver" or something).
> BTW: I don't like -Wshadow.

Let me guess - and Wconst too?

/src/sys/dev/pci/ifpci.c: In function `avma1pp_write_fifo':
/src/sys/dev/pci/ifpci.c:486: warning: cast discards qualifiers from pointer target type
/src/sys/dev/pci/ifpci.c:486: warning: cast discards qualifiers from pointer target type
/src/sys/dev/pci/ifpci.c: In function `hscx_write_fifo':
/src/sys/dev/pci/ifpci.c:518: warning: cast discards qualifiers from pointer target type

There seems to be serious bitrot in the ISDN code - why is this not in the 
GENERIC kernel so it gets compiled every now and then?


  - Hubert