Subject: Re: libradius broken on amd64
To: Paulo Alexandre Pinto Pires <p@ppires.org>
From: Martin Husemann <martin@duskware.de>
List: current-users
Date: 02/20/2005 23:30:20
On Sun, Feb 20, 2005 at 06:47:38PM -0300, Paulo Alexandre Pinto Pires wrote:
> I remember at least one less obvious situation like
> 
> padded_len = h->pass_len == 0 ? 16 : (h->pass_len+15) & ~0xf;
>  
> 
> where padded_len is int and the field pass_len in struct rad_handle is 
> size_t, which is long.

Yes, this is a potential problem and it should warn about it. It just should
not hide it in between tons of bogus warnings (which, by far, outcount the
real ones in the example at hand)

Martin