Subject: Re: CVS commit: src/lib/libc/arch/i386/string
To: None <mason@primenet.com.au>
From: J.T. Conklin <jtc@acorntoolworks.com>
List: current-users
Date: 02/05/2005 16:37:31
Geoff Wing <mason@primenet.com.au> writes:
> Geoff Wing <mason@primenet.com.au> typed:
> : anyone else having problems with these new versions?  My Jan24 libc is
> : working fine and with these has problems (and reverting getcwd.c didn't fix
> : it).  I'll try to isolate it in the next few days if someone else hasn't.
>
> It's memchr.S causing problems. memchr.S:1.10 works fine.

I found a bug that would cause problems with unaligned buffers less
than 3 bytes long.  

FWIW, I didn't make the same mistake with the AMD64 version, so that
is OK.

My appologies to Geoff and anyone effected by this bug.

    --jtc

*** memchr.S	2004/04/14 02:10:40	1.8
--- memchr.S	2005/02/06 00:33:27
***************
*** 29,34 ****
--- 29,35 ----
  	incl	%eax
  	decl	%esi
  	jnz	.Lalign
+ 	jmp	.Lzero
  	
  .Lword_aligned:
  	/* copy char to all bytes in word */

-- 
J.T. Conklin