Subject: Re: disk performance on -current
To: Kouichirou Hiratsuka <hira@po6.nsk.ne.jp>
From: enami tsugutomo <enami@sm.sony.co.jp>
List: current-users
Date: 01/27/2005 10:51:23
Kouichirou Hiratsuka <hira@po6.nsk.ne.jp> writes:

>   http://mail-index.NetBSD.org/source-changes/2005/01/25/0028.html

At least, this looks inconsistent.

enami.

Index: ffs_vnops.c
===================================================================
RCS file: /cvsroot/src/sys/ufs/ffs/ffs_vnops.c,v
retrieving revision 1.67
diff -c -r1.67 ffs_vnops.c
*** ffs_vnops.c	25 Jan 2005 23:55:21 -0000	1.67
--- ffs_vnops.c	27 Jan 2005 01:37:19 -0000
***************
*** 461,467 ****
  		waitfor = (ap->a_flags & FSYNC_WAIT) ? UPDATE_WAIT : 0;
  	error = VOP_UPDATE(vp, NULL, NULL, waitfor);
  
! 	if (error == 0 && ap->a_flags & FSYNC_WAIT) {
  		int i = 0;
  		VOP_IOCTL(VTOI(vp)->i_devvp, DIOCCACHESYNC, &i, FWRITE,
  			ap->a_p->p_ucred, ap->a_p);
--- 465,471 ----
  		waitfor = (ap->a_flags & FSYNC_WAIT) ? UPDATE_WAIT : 0;
  	error = VOP_UPDATE(vp, NULL, NULL, waitfor);
  
! 	if (error == 0 && ap->a_flags & FSYNC_CACHE) {
  		int i = 0;
  		VOP_IOCTL(VTOI(vp)->i_devvp, DIOCCACHESYNC, &i, FWRITE,
  			ap->a_p->p_ucred, ap->a_p);