Subject: Re: i386 acpi kernel build failure
To: None <sverre@viewmark.com>
From: Takayoshi Kochi <kochi@netbsd.org>
List: current-users
Date: 04/12/2004 10:37:53
----Next_Part(Mon_Apr_12_10:37:53_2004_241)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Sorry, please try attached patch.

I can't test it now, but should work.

I'll test this later myself and commit.
Thanks for pointing out.

From: Sverre Froyen <sverre@viewmark.com>
Subject: i386 acpi kernel build failure
Date: Sun, 11 Apr 2004 12:20:00 -0600

> Hi,
> 
> A kernel build of current (2.0?) sources from this morning fails with:
> 
> #   compile  ABBOR2/acpi_resource.o
> /usr/src/tooldir.i386/bin/i386--netbsdelf-gcc -ffreestanding -O2 -Werror 
> -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith 
> -Wmissing-prototypes -Wstrict-prototypes -Wno-sign-compare -Di386 -I. 
> -I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DLKM 
> -DMSGBUFSIZE=10000000 -DUSB_DEBUG -DUHCI_DEBUG -DACPI_EXTRA_DEBUG 
> -DACPI_ACAD_DEBUG -DACPI_BUT_DEBUG -DACPI_FDC_DEBUG -DACPI_LID_DEBUG 
> -DACPI_MADT_DEBUG -DPCMCIADEBUG -DPCMCIACISDEBUG -DACPICA_PEDANTIC 
> -DMAXUSERS=32 -D_KERNEL -D_KERNEL_OPT 
> -c /usr/src/sys/dev/acpi/acpi_resource.c
> /usr/src/sys/dev/acpi/acpi_resource.c: In function 
> `acpi_resource_parse_callback':
> /usr/src/sys/dev/acpi/acpi_resource.c:102: error: `_Dbg' undeclared 
> (first use in this function)
> /usr/src/sys/dev/acpi/acpi_resource.c:102: error: (Each undeclared 
> identifier is reported only once
> /usr/src/sys/dev/acpi/acpi_resource.c:102: error: for each function it 
> appears in.)
> 
> *** Failed target:  acpi_resource.o
> 
> Missing header file when acpi debug options are enabled?
> 
> Sverre

----Next_Part(Mon_Apr_12_10:37:53_2004_241)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="acpi_resource.c.diff"

Index: acpi_resource.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_resource.c,v
retrieving revision 1.14
diff -u -r1.14 acpi_resource.c
--- acpi_resource.c	11 Apr 2004 10:36:35 -0000	1.14
+++ acpi_resource.c	12 Apr 2004 01:35:21 -0000
@@ -95,6 +95,8 @@
 	const struct acpi_resource_parse_ops *ops;
 	int i;
 
+	ACPI_FUNCTION_TRACE(__FUNCTION__);
+
 	ops = arg->ops;
 
 	switch (res->Id) {
@@ -262,7 +264,7 @@
 		break;
 	}
 
-	return AE_OK;
+	return_ACPI_STATUS(AE_OK);
 }
 
 

----Next_Part(Mon_Apr_12_10:37:53_2004_241)----