Subject: Re: important: make changes
To: Christos Zoulas <christos@zoulas.com>
From: Andrew Brown <atatat@atatdot.net>
List: current-users
Date: 01/15/2001 01:54:34
>foo:
>.if !commands(foo)
>	echo 2
>.endif
>
>In order for your make build to succeed, please make sure that you rebuild
>make(1) before you install the new rules in /usr/src/share/mk, so that
>the commands(<target>) directive gets recognized.

imho, this is the "wrong" solution.  the makefiles in question
(etc/Makefile et al, for example) should be modified to not emit to
sets of commands.

for the etc set, both etc/Makefile and, eg, etc/etc.i386/Makefile.inc
define a snap_md_post target with commands.  in the former, it is
"protected" by ".if !defined(RELEASEDIR)" and ".ifndef DESTDIR"
whereas in the latter it is not "protected" at all.  adjusting the
port makefiles would be, i think, a more proper solution.  the target
in the md makefiles should probably be protected by something checking
the value of RELEASEDIR.  snap_md_post isn't very useful if that's not
set.

this, of course, says nothing of the mixed use of ".if !defined" and
".ifndef" in different places.  :)

-- 
|-----< "CODE WARRIOR" >-----|
codewarrior@daemon.org             * "ah!  i see you have the internet
twofsonet@graffiti.com (Andrew Brown)                that goes *ping*!"
andrew@crossbar.com       * "information is power -- share the wealth."