Subject: Apr. 5 build failure: ucom.c
To: None <current-users@netbsd.org>
From: Chris Jones <cjones@rightnowtech.com>
List: current-users
Date: 04/05/2000 13:15:30
--=-=-=

Script started on Wed Apr  5 12:52:38 2000
reddwarf$ make
cc  -O2 -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes  -Wpointer-arith -Wno-main -I. -I../../../../arch -I../../../.. -nostdinc -I../../../../../crypto-us/sys -I../../../../../gnu/sys -DLKM -DDIAGNOSTIC -DMAXUSERS=32 -D_KERNEL -Di386  -c ../../../../dev/usb/ucom.c
cc1: warnings being treated as errors
../../../../dev/usb/ucom.c:727: warning: static declaration for `ucom_status_change' follows non-static
../../../../dev/usb/ucom.c:899: warning: static declaration for `ucomstop' follows non-static
../../../../dev/usb/ucom.c:1035: warning: static declaration for `ucomprint' follows non-static
../../../../dev/usb/ucom.c:1046: warning: static declaration for `ucomsubmatch' follows non-static
../../../../dev/usb/ucom.c:1035: warning: `ucomprint' defined but not used
../../../../dev/usb/ucom.c:1046: warning: `ucomsubmatch' defined but not used
../../../../dev/usb/ucom.c:899: warning: `ucomstop' defined but not used
*** Error code 1

Stop.
reddwarf$ exit
Script done on Wed Apr  5 12:53:55 2000

/*	$NetBSD: ucom.c,v 1.17 2000/04/05 11:11:33 augustss Exp $	*/
/*	$NetBSD: ucomvar.h,v 1.2 2000/02/08 09:18:02 augustss Exp $	*/

The following patch seems to fix it, but I'd like somebody (augustss)
to review before I commit it:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=usb-patch
Content-Description: Patch to fix USB problem.

Index: ucom.c
===================================================================
RCS file: /cvsroot/syssrc/sys/dev/usb/ucom.c,v
retrieving revision 1.17
diff -u -w -r1.17 ucom.c
--- ucom.c	2000/04/05 11:11:33	1.17
+++ ucom.c	2000/04/05 19:13:05
@@ -131,6 +131,7 @@
 				     int, struct proc *));
 Static void	ucom_dtr	__P((struct ucom_softc *, int));
 Static void	ucom_rts	__P((struct ucom_softc *, int));
+Static void	ucom_status_change __P((struct ucom_softc *));
 Static void	ucom_break	__P((struct ucom_softc *, int));
 Static usbd_status ucomstartread __P((struct ucom_softc *));
 Static void	ucomreadcb	__P((usbd_xfer_handle, usbd_private_handle, 
@@ -894,7 +895,7 @@
 	splx(s);
 }
 
-Static void
+void
 ucomstop(tp, flag)
 	struct tty *tp;
 	int flag;
@@ -1030,7 +1031,7 @@
 
 #endif /* NUCOM > 0 */
 
-Static int
+int
 ucomprint(aux, pnp)
 	void *aux;
 	const char *pnp;
@@ -1041,7 +1042,7 @@
 	return (UNCONF);
 }
 
-Static int
+int
 ucomsubmatch(parent, cf, aux)
 	struct device *parent;
 	struct cfdata *cf;
Index: ucomvar.h
===================================================================
RCS file: /cvsroot/syssrc/sys/dev/usb/ucomvar.h,v
retrieving revision 1.2
diff -u -w -r1.2 ucomvar.h
--- ucomvar.h	2000/02/08 09:18:02	1.2
+++ ucomvar.h	2000/04/05 19:13:05
@@ -101,4 +101,3 @@
 
 int ucomprint __P((void *aux, const char *pnp));
 int ucomsubmatch __P((struct device *parent, struct cfdata *cf, void *aux));
-void ucom_status_change __P((struct ucom_softc *sc));

--=-=-=


Chris

-- 
---------------------------------------------------- cjones@rightnowtech.com
Chris Jones
           System Administrator, Right Now Technologies, Inc.
"Is this going to be a stand-up programming session, sir, or another bug hunt?"

--=-=-=--