Subject: Re: -current make in src/sbin/raidctl
To: Andreas Wrede <andreas@planix.com>
From: Greg Oster <oster@cs.usask.ca>
List: current-users
Date: 03/24/1999 09:06:48
Andreas Wrede writes:
> make build in current, sup'ed yesterday, failes in src/sbin/raidctl:
> 
> cc -O2 -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes
> -Wpointer-arith -Werror -Wno-error 
> -I/usr/src/sbin/raidctl/../../sys/dev/raidframe -c rf_configure.c
> rf_configure.c: In function `osf_dev_name2num':
> rf_configure.c:390: `RF_SCSI_DISK_MAJOR' undeclared (first use in this
> function)
> rf_configure.c:390: (Each undeclared identifier is reported only once
> rf_configure.c:390: for each function it appears in.)
> *** Error code 1

Umm.....  There are supposed to be some more COPT's in that compile line. 
Specifically: 
  
   -DCSRG_BASED -DNARROWPROTO -DRF_UTILITY=1 -DSIMULATE=1

If you look in the Makefile, you'll see them there...  For some reason
they're getting missed when you do your make...  (Hmm.. I wonder if something
with COPTS has changed recently with 'make'.  Nuke the 'COPTS+=...' line
in /usr/src/sbin/raidctl/Makefile, and replace the line 'CPPFLAGS+=...'
with:

CPPFLAGS+= -DCSRG_BASED -DNARROWPROTO -DRF_UTILITY=1 -DSIMULATE=1 -I${LOOKHERE}

I'll dig into this further in a bit..)

> I re-supped, ftp'd fresh sources from src/sys/dev/raidframe and
> src/sbin/raidctl and ftp'd snap-19990315 all with the same result: a
> define for RF_SCSI_DISK_MAJOR is nowhere to be found.

Ya.  It disappeared from src/sys/dev/raidframe/rf_raidframe.h during 
cleanup a while back.  Unfortunately I've not had time to cleanup
rf_configure.c like I've wanted to... :-(  For raidctl, however, 
RF_SCSI_DISK_MAJOR isn't needed at all, and it not being defined is
not the real problem.

Later...

Greg Oster