New Defects reported by Coverity Scan for NetBSD-amd64-kernel

[scan-admin%coverity.com@localhost]

Hi,

Please find the latest report on new defect(s) introduced to NetBSD-amd64-kernel found with Coverity Scan.

2 new defect(s) introduced to NetBSD-amd64-kernel found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1363344:  Control flow issues  (DEADCODE)
/sys/netinet/ip_input.c: 1475 in ip_savecontrol()


________________________________________________________________________________________________________
*** CID 1363344:  Control flow issues  (DEADCODE)
/sys/netinet/ip_input.c: 1475 in ip_savecontrol()
1469     		if (*mp)
1470     			mp = &(*mp)->m_next;
1471     	}
1472     	if (inpflags & INP_RECVIF) {
1473     		struct sockaddr_dl sdl;
1474     
>>>     CID 1363344:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "0" inside this statement: "sockaddr_dl_init(&sdl, 20U,...".
1475     		sockaddr_dl_init(&sdl, sizeof(sdl), ifp ?
1476     		    ifp->if_index : 0, 0, NULL, 0, NULL, 0);
1477     		*mp = sbcreatecontrol(&sdl, sdl.sdl_len, IP_RECVIF, IPPROTO_IP);
1478     		if (*mp)
1479     			mp = &(*mp)->m_next;
1480     	}

** CID 1363345:  Control flow issues  (UNREACHABLE)
/sys/netinet6/in6.c: 1292 in in6_update_ifa1()


________________________________________________________________________________________________________
*** CID 1363345:  Control flow issues  (UNREACHABLE)
/sys/netinet6/in6.c: 1292 in in6_update_ifa1()
1286     	return error;
1287     
1288     	/*
1289     	 * XXX: if a change of an existing address failed, keep the entry
1290     	 * anyway.
1291     	 */
>>>     CID 1363345:  Control flow issues  (UNREACHABLE)
>>>     This code cannot be reached: "if (hostIsNew)
  in6_unlink...".
1292     	if (hostIsNew)
1293     		in6_unlink_ifa(ia, ifp);
1294       exit:
1295     	return error;
1296     
1297       cleanup:


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/netbsd-amd64-kernel?tab=overview

To manage Coverity Scan email notifications for "coverity-updates%netbsd.org@localhost", click https://scan.coverity.com/subscriptions/edit?email=coverity-updates%40netbsd.org&token=487286ca1a9a4f4bd485d16f66b5e782