Coverity-updates archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

New Defects reported by Coverity Scan for NetBSD-i386-user



Hi,

Please find the latest report on new defect(s) introduced to NetBSD-i386-user found with Coverity Scan.

65 new defect(s) introduced to NetBSD-i386-user found with Coverity Scan.
12 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 65 defect(s)


** CID 461508:  Resource leaks  (RESOURCE_LEAK)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 3655 in ExecuteFunction()


________________________________________________________________________________________________________
*** CID 461508:  Resource leaks  (RESOURCE_LEAK)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 3655 in ExecuteFunction()
3649         case F_QUIT:
3650     	Done(0);
3651     	break;
3652         }
3653     
3654         if (ButtonPressed == -1) XUngrabPointer(dpy, CurrentTime);
>>>     CID 461508:  Resource leaks  (RESOURCE_LEAK)
>>>     Returning without freeing "action" leaks the storage that it points to.
3655         return do_next_action;
3656     }
3657     
3658     
3659     
3660     /***********************************************************************

** CID 1322878:  Control flow issues  (DEADCODE)
/sys/netinet/if_arp.c: 855 in arpresolve()


________________________________________________________________________________________________________
*** CID 1322878:  Control flow issues  (DEADCODE)
/sys/netinet/if_arp.c: 855 in arpresolve()
849     		la = lla_create(LLTABLE(ifp), flags, dst);
850     		IF_AFDATA_WUNLOCK(ifp);
851     	}
852     
853     	if (la == NULL) {
854     		if (create) {
>>>     CID 1322878:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "log(7, "%s: failed to creat...".
855     			log(LOG_DEBUG,
856     			    "%s: failed to create llentry for %s on %s\n",
857     			    __func__, inet_ntoa(satocsin(dst)->sin_addr),
858     			    ifp->if_xname);
859     		}
860     		m_freem(m);

** CID 1322879:  Control flow issues  (DEADCODE)
/sys/netinet/if_arp.c: 840 in arpresolve()


________________________________________________________________________________________________________
*** CID 1322879:  Control flow issues  (DEADCODE)
/sys/netinet/if_arp.c: 840 in arpresolve()
834     	if (la == NULL) {
835     		IF_AFDATA_RLOCK(ifp);
836     		la = lla_lookup(LLTABLE(ifp), flags, dst);
837     		IF_AFDATA_RUNLOCK(ifp);
838     	}
839     
>>>     CID 1322879:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "(ifp->if_flags & 0x80) == 0" inside this statement: "if (la == NULL && (flags & ...".
840     	if ((la == NULL) && ((flags & LLE_EXCLUSIVE) == 0)
841     #ifdef __FreeBSD__
842     	    && ((ifp->if_flags & (IFF_NOARP | IFF_STATICARP)) == 0)) {
843     #else
844     	    && ((ifp->if_flags & IFF_NOARP) == 0)) {
845     #endif

** CID 1322880:    (REVERSE_INULL)
/sys/netinet/if_arp.c: 908 in arpresolve()
/sys/netinet/if_arp.c: 920 in arpresolve()


________________________________________________________________________________________________________
*** CID 1322880:    (REVERSE_INULL)
/sys/netinet/if_arp.c: 908 in arpresolve()
902     		m_freem(m);
903     		error = EINVAL;
904     		goto done;
905     	}
906     
907     	renew = (la->la_asked == 0 || la->la_expire != time_uptime);
>>>     CID 1322880:    (REVERSE_INULL)
>>>     Null-checking "m" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
908     	if ((renew || m != NULL) && (flags & LLE_EXCLUSIVE) == 0) {
909     		flags |= LLE_EXCLUSIVE;
910     		LLE_RUNLOCK(la);
911     		la = NULL;
912     		goto retry;
913     	}
/sys/netinet/if_arp.c: 920 in arpresolve()
914     	/*
915     	 * There is an arptab entry, but no ethernet address
916     	 * response yet.  Add the mbuf to the list, dropping
917     	 * the oldest packet if we have exceeded the system
918     	 * setting.
919     	 */
>>>     CID 1322880:    (REVERSE_INULL)
>>>     Null-checking "m" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
920     	if (m != NULL) {
921     		LLE_WLOCK_ASSERT(la);
922     		if (la->la_numheld >= arp_maxhold) {
923     			if (la->la_hold != NULL) {
924     				struct mbuf *next = la->la_hold->m_nextpkt;
925     				m_freem(la->la_hold);

** CID 1322881:  Error handling issues  (CHECKED_RETURN)
/home/phil/cov/xsrc/external/mit/ctwm/dist/parse.c: 2128 in start_m4()


________________________________________________________________________________________________________
*** CID 1322881:  Error handling issues  (CHECKED_RETURN)
/home/phil/cov/xsrc/external/mit/ctwm/dist/parse.c: 2128 in start_m4()
2122             int fno;
2123             int fids[2];
2124             int fres;               /* Fork result */
2125     
2126             fno = fileno(fraw);
2127             /* if (-1 == fcntl(fno, F_SETFD, 0)) perror("fcntl()"); */
>>>     CID 1322881:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "pipe" without checking return value (as is done elsewhere 122 out of 140 times).
2128             pipe(fids);
2129             fres = fork();
2130             if (fres < 0) {
2131                     perror("Fork for " M4CMD " failed");
2132                     exit(23);
2133             }

** CID 1322882:  Error handling issues  (CHECKED_RETURN)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 1822 in resizeFromCenter()


________________________________________________________________________________________________________
*** CID 1322882:  Error handling issues  (CHECKED_RETURN)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 1822 in resizeFromCenter()
1816     	  MenuEndResize(tmp_win);
1817     	  XMoveResizeWindow(dpy, w, AddingX, AddingY, AddingW, AddingH);
1818     	  break;
1819     	}
1820           
1821           if (Event.type != MotionNotify) {
>>>     CID 1322882:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "DispatchEvent2" without checking return value (as is done elsewhere 4 out of 5 times).
1822     	DispatchEvent2 ();
1823     	continue;
1824           }
1825           
1826           /*
1827            * XXX - if we are going to do a loop, we ought to consider

** CID 1322883:  Error handling issues  (CHECKED_RETURN)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 788 in UpdateMenu()


________________________________________________________________________________________________________
*** CID 1322883:  Error handling issues  (CHECKED_RETURN)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 788 in UpdateMenu()
782     	    &x_root, &y_root, &x, &y, &JunkMask);
783     
784     	/* if we haven't recieved the enter notify yet, wait */
785     	if (ActiveMenu && !ActiveMenu->entered)
786     	    continue;
787     
>>>     CID 1322883:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "XFindContext" without checking return value (as is done elsewhere 52 out of 54 times).
788     	XFindContext(dpy, ActiveMenu->w, ScreenContext, (XPointer *)&Scr);
789     
790     	if (x < 0 || y < 0 ||
791     	    x >= ActiveMenu->width || y >= ActiveMenu->height)
792     	{
793     	    if (ActiveItem && ActiveItem->func != F_TITLE)

** CID 1322884:    (DC.WEAK_CRYPTO)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 5003 in MosaicFade()
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 5004 in MosaicFade()


________________________________________________________________________________________________________
*** CID 1322884:    (DC.WEAK_CRYPTO)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 5003 in MosaicFade()
4997         for (j = 0; j < nrects; j++) {
4998     	rectangles [j].width  = srect;
4999     	rectangles [j].height = srect;
5000         }
5001         for (i = 0; i < 10; i++) {
5002     	for (j = 0; j < nrects; j++) {
>>>     CID 1322884:    (DC.WEAK_CRYPTO)
>>>     "lrand48" should not be used for security related applications, as linear congruential algorithms are too easy to break.
5003     	    rectangles [j].x = ((lrand48 () %  width) / srect) * srect;
5004     	    rectangles [j].y = ((lrand48 () % height) / srect) * srect;
5005     	}
5006     	XFillRectangles (dpy, mask, gc, rectangles, nrects);
5007     	XShapeCombineMask (dpy, blanket, ShapeBounding, 0, 0, mask, ShapeSet);
5008     	XFlush (dpy);
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 5004 in MosaicFade()
4998     	rectangles [j].width  = srect;
4999     	rectangles [j].height = srect;
5000         }
5001         for (i = 0; i < 10; i++) {
5002     	for (j = 0; j < nrects; j++) {
5003     	    rectangles [j].x = ((lrand48 () %  width) / srect) * srect;
>>>     CID 1322884:    (DC.WEAK_CRYPTO)
>>>     "lrand48" should not be used for security related applications, as linear congruential algorithms are too easy to break.
5004     	    rectangles [j].y = ((lrand48 () % height) / srect) * srect;
5005     	}
5006     	XFillRectangles (dpy, mask, gc, rectangles, nrects);
5007     	XShapeCombineMask (dpy, blanket, ShapeBounding, 0, 0, mask, ShapeSet);
5008     	XFlush (dpy);
5009     	waitamoment (0.020);

** CID 1322885:  Possible Control flow issues  (DEADCODE)
/home/phil/cov/xsrc/external/mit/ctwm/dist/vscreen.c: 59 in InitVirtualScreens()


________________________________________________________________________________________________________
*** CID 1322885:  Possible Control flow issues  (DEADCODE)
/home/phil/cov/xsrc/external/mit/ctwm/dist/vscreen.c: 59 in InitVirtualScreens()
53           vs->window = scr->Root;
54           vs->next   = NULL;
55           scr->vScreenList = vs;
56           scr->currentvs   = vs;
57           return;
58         } else {
>>>     CID 1322885:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "scr->VirtualScreens = (name...".
59           scr->VirtualScreens = (name_list*) malloc (sizeof (name_list));
60           scr->VirtualScreens->next = NULL;
61           scr->VirtualScreens->name = (char*) malloc (64);
62           sprintf (scr->VirtualScreens->name, "%dx%d+0+0", scr->rootw, scr->rooth);
63         }
64       }

** CID 1322886:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 484 in InitTitlebarButtons()


________________________________________________________________________________________________________
*** CID 1322886:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 484 in InitTitlebarButtons()
478     	    tb->image = GetImage (TBPM_QUESTION, Scr->TitleC);
479     	    if (!tb->image) {		/* cannot happen (see util.c) */
480     		fprintf (stderr, "%s:  unable to add titlebar button \"%s\"\n",
481     			 ProgramName, tb->name);
482     	    }
483     	}
>>>     CID 1322886:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "tb->image".
484     	tb->width  = tb->image->width;
485     	tb->height = tb->image->height;
486     	tb->dstx = (h - tb->width + 1) / 2;
487     	if (tb->dstx < 0) {		/* clip to minimize copying */
488     	    tb->srcx = -(tb->dstx);
489     	    tb->width = h;

** CID 1322887:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/util.c: 2885 in PaintTitleButtons()


________________________________________________________________________________________________________
*** CID 1322887:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/util.c: 2885 in PaintTitleButtons()
2879     void PaintTitleButtons (TwmWindow *tmp_win)
2880     {
2881         int i;
2882         TBWindow *tbw;
2883         int nb = Scr->TBInfo.nleft + Scr->TBInfo.nright;
2884     
>>>     CID 1322887:  Null pointer dereferences  (FORWARD_NULL)
>>>     Incrementing null pointer "tbw".
2885         for (i = 0, tbw = tmp_win->titlebuttons; i < nb; i++, tbw++) {
2886     	if (tbw) PaintTitleButton (tmp_win, tbw);
2887         }
2888     }
2889     
2890     void adoptWindow (void)

** CID 1322888:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4124 in UnmapTransients()


________________________________________________________________________________________________________
*** CID 1322888:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4124 in UnmapTransients()
4118         for (t = Scr->FirstWindow; t != NULL; t = t->next) {
4119     	if (t != tmp_win &&
4120     		((t->transient && t->transientfor == tmp_win->w) ||
4121     		 t->group == tmp_win->w)) {
4122     	    if (iconify) {
4123     		if (t->icon_on)
>>>     CID 1322888:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "tmp_win->icon".
4124     		    Zoom(t->icon->w, tmp_win->icon->w);
4125     		else if (tmp_win->icon)
4126     		    Zoom(t->frame, tmp_win->icon->w);
4127     	    }
4128     
4129     	    /*

** CID 1322889:    (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 1348 in DisplayWin()
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 1374 in DisplayWin()


________________________________________________________________________________________________________
*** CID 1322889:    (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 1348 in DisplayWin()
1342     		if (tmp_win->icon && tmp_win->icon->w) {
1343     		    if (vs != tmp_win->old_parent_vs) {
1344     			int x, y;
1345     			unsigned int junk;
1346     			Window junkW, w = tmp_win->icon->w;
1347     			XGetGeometry (dpy, w, &junkW, &x, &y, &junk, &junk, &junk, &junk);
>>>     CID 1322889:    (FORWARD_NULL)
>>>     Dereferencing null pointer "vs".
1348     			XReparentWindow (dpy, w, vs->window, x, y);
1349     		    }
1350     
1351     		    IconUp (tmp_win);
1352     		    XMapWindow (dpy, tmp_win->icon->w);
1353     		    return;
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 1374 in DisplayWin()
1368     	    eventMask = winattrs.your_event_mask;
1369     	    XSelectInput (dpy, tmp_win->w, eventMask & ~StructureNotifyMask);
1370     	    XMapWindow   (dpy, tmp_win->w);
1371     	    XSelectInput (dpy, tmp_win->w, eventMask);
1372     	}
1373     	if (vs != tmp_win->old_parent_vs) {
>>>     CID 1322889:    (FORWARD_NULL)
>>>     Dereferencing null pointer "vs".
1374     	    XReparentWindow (dpy, tmp_win->frame, vs->window, tmp_win->frame_x, tmp_win->frame_y);
1375     	}
1376     	XMapWindow (dpy, tmp_win->frame);
1377     	SetMapStateProp (tmp_win, NormalState);
1378         }
1379     }

** CID 1322890:    (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 3082 in HandleButtonPress()
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 3082 in HandleButtonPress()


________________________________________________________________________________________________________
*** CID 1322890:    (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 3082 in HandleButtonPress()
3076     		Event.xbutton.subwindow = child;
3077     	    }
3078     	}
3079     	else
3080     	    Context = C_ROOT;
3081         }
>>>     CID 1322890:    (FORWARD_NULL)
>>>     Comparing "Tmp_win" to null implies that "Tmp_win" might be null.
3082         if (Tmp_win)
3083         {
3084     	if (Tmp_win->iconmanagerlist && (RootFunction != 0) &&
3085     		((Event.xany.window == Tmp_win->iconmanagerlist->icon) ||
3086     		 (Event.xany.window == Tmp_win->iconmanagerlist->w))) {
3087     	    Tmp_win = Tmp_win->iconmanagerlist->iconmgr->twm_win;
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 3082 in HandleButtonPress()
3076     		Event.xbutton.subwindow = child;
3077     	    }
3078     	}
3079     	else
3080     	    Context = C_ROOT;
3081         }
>>>     CID 1322890:    (FORWARD_NULL)
>>>     Comparing "Tmp_win" to null implies that "Tmp_win" might be null.
3082         if (Tmp_win)
3083         {
3084     	if (Tmp_win->iconmanagerlist && (RootFunction != 0) &&
3085     		((Event.xany.window == Tmp_win->iconmanagerlist->icon) ||
3086     		 (Event.xany.window == Tmp_win->iconmanagerlist->w))) {
3087     	    Tmp_win = Tmp_win->iconmanagerlist->iconmgr->twm_win;

** CID 1322891:    (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 1164 in HandleKeyPress()
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 1194 in HandleKeyPress()


________________________________________________________________________________________________________
*** CID 1322891:    (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 1164 in HandleKeyPress()
1158     			if (ActiveMenu == Scr->Workspaces) {
1159     			    PopDownMenu();
1160     			    XUngrabPointer  (dpy, CurrentTime);
1161     			    GotoWorkSpaceByName (Scr->currentvs, item->action + 8);
1162     			}
1163     			else {
>>>     CID 1322891:    (FORWARD_NULL)
>>>     Comparing "ButtonWindow" to null implies that "ButtonWindow" might be null.
1164     			    ExecuteFunction (item->func, item->action,
1165     				ButtonWindow ? ButtonWindow->frame : None,
1166     				ButtonWindow, &Event, Context, FALSE);
1167     			    PopDownMenu();
1168     			}
1169     			return;
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 1194 in HandleKeyPress()
1188     		    do_key_menu (item->sub, None);
1189     		    CurrentSelectedWorkspace = NULL;
1190     		    break;
1191     
1192     		default :
1193     		    if (item->func != F_PIN) PopDownMenu();
>>>     CID 1322891:    (FORWARD_NULL)
>>>     Comparing "ButtonWindow" to null implies that "ButtonWindow" might be null.
1194     		    ExecuteFunction (item->func, item->action,
1195     			ButtonWindow ? ButtonWindow->frame : None,
1196     			ButtonWindow, &Event, Context, FALSE);
1197     	    }
1198     	}
1199     	else {

** CID 1322892:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4105 in DeIconify()


________________________________________________________________________________________________________
*** CID 1322892:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4105 in DeIconify()
4099         ReMapTransients(tmp_win);
4100     
4101         if (! Scr->WindowMask && Scr->DeIconifyFunction.func != 0) {
4102     	char *action;
4103     	XEvent event;
4104     
>>>     CID 1322892:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "action" = "NULL".
4105     	action = Scr->DeIconifyFunction.item ?
4106     		Scr->DeIconifyFunction.item->action : NULL;
4107     	ExecuteFunction (Scr->DeIconifyFunction.func, action,
4108     			   (Window) 0, tmp_win, &event, C_ROOT, FALSE);
4109         }
4110         XSync (dpy, 0);

** CID 1322893:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4084 in DeIconify()


________________________________________________________________________________________________________
*** CID 1322893:  Null pointer dereferences  (FORWARD_NULL)
/home/phil/cov/xsrc/external/mit/ctwm/dist/menus.c: 4084 in DeIconify()
4078     	isicon = TRUE;
4079     	if (tmp_win->icon_on && tmp_win->icon && tmp_win->icon->w)
4080     	    Zoom(tmp_win->icon->w, tmp_win->frame);
4081     	else if (tmp_win->group != (Window) 0)
4082     	{
4083     	    t = GetTwmWindow(tmp_win->group);
>>>     CID 1322893:  Null pointer dereferences  (FORWARD_NULL)
>>>     Comparing "t" to null implies that "t" might be null.
4084     	    if (t && t->icon_on && t->icon && t->icon->w)
4085     	    {
4086     		Zoom(t->icon->w, tmp_win->frame);
4087     	    }
4088     	}
4089         }

** CID 1322894:  Insecure data handling  (INTEGER_OVERFLOW)
/home/phil/cov/xsrc/external/mit/ctwm/dist/util.c: 3318 in LoadXwdImage()


________________________________________________________________________________________________________
*** CID 1322894:  Insecure data handling  (INTEGER_OVERFLOW)
/home/phil/cov/xsrc/external/mit/ctwm/dist/util.c: 3318 in LoadXwdImage()
3312         if (*(char *) &swaptest) _swaplong ((char *) &header, sizeof (header));
3313         if (header.file_version != XWD_FILE_VERSION) {
3314     	fprintf(stderr,"ctwm: XWD file format version mismatch : %s\n", filename);
3315     	return (None);
3316         }
3317         win_name_size = header.header_size - sizeof (header);
>>>     CID 1322894:  Insecure data handling  (INTEGER_OVERFLOW)
>>>     Overflowed or truncated value (or a value computed from an overflowed or truncated value) "win_name_size" used as critical argument to function. [Note: The source code implementation of the function has been overridden by a builtin model.]
3318         len = fread (win_name, win_name_size, 1, file);
3319         if (len != 1) {
3320     	fprintf (stderr, "file %s has not the correct format\n", filename);
3321     #ifdef USE_SIGNALS
3322     	if (ispipe && anim) StartAnimation ();
3323     #endif

** CID 1322895:  Control flow issues  (MISSING_BREAK)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2722 in WMgrHandleButtonEvent()


________________________________________________________________________________________________________
*** CID 1322895:  Control flow issues  (MISSING_BREAK)
/home/phil/cov/xsrc/external/mit/ctwm/dist/workmgr.c: 2722 in WMgrHandleButtonEvent()
2716     	Scr->OpaqueMove = FALSE;
2717         }
2718         switch (button) {
2719     	case 1 :
2720     	    XUnmapWindow (dpy, sw);
2721     
>>>     CID 1322895:  Control flow issues  (MISSING_BREAK)
>>>     The above case falls through to this one.
2722     	case 2 :
2723     	    XGetGeometry (dpy, sw, &junkW, &X0, &Y0, &W0, &H0, &bw, &junk);
2724     	    XTranslateCoordinates (dpy, vs->wsw->mswl [oldws->number]->w,
2725     				mw->w, X0, Y0, &X1, &Y1, &junkW);
2726     
2727     	    attrs.event_mask       = ExposureMask;

** CID 1322896:  Control flow issues  (MISSING_BREAK)
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 1126 in HandleKeyPress()


________________________________________________________________________________________________________
*** CID 1322896:  Control flow issues  (MISSING_BREAK)
/home/phil/cov/xsrc/external/mit/ctwm/dist/events.c: 1126 in HandleKeyPress()
1120     			if ((modifier & Mod1Mask) &&
1121     			    (keynam [0] == Tolower (item->item [1])))
1122     			    matched = True;
1123     			break;
1124     		    case ' ' :
1125     			offset = 1;
>>>     CID 1322896:  Control flow issues  (MISSING_BREAK)
>>>     The above case falls through to this one.
1126     		    default :
1127     			if (((Scr->IgnoreCaseInMenuSelection) &&
1128     			    (keynam [0] == Tolower (item->item [offset]))) ||
1129     
1130     			     ((modifier & ShiftMask) && Isupper (item->item [offset]) &&
1131     			     (keynam [0] == Tolower (item->item [offset]))) ||


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/netbsd-i386-user?tab=overview

To manage Coverity Scan email notifications for "coverity-updates%netbsd.org@localhost", click https://scan.coverity.com/subscriptions/edit?email=coverity-updates%40netbsd.org&token=487286ca1a9a4f4bd485d16f66b5e782



Home | Main Index | Thread Index | Old Index