Coverity-updates archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

New Defects reported by Coverity Scan for NetBSD-i386-kernel



Hi,

Please find the latest report on new defect(s) introduced to NetBSD-i386-kernel found with Coverity Scan.

1475 new defect(s) introduced to NetBSD-i386-kernel found with Coverity Scan.
47 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 1475 defect(s)


** CID 113228:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/atombios_crtc.c: 136 in atombios_scaler_setup()

** CID 113231:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_atombios.c: 972 in radeon_get_atom_connector_info_from_supported_devices_table()

** CID 113251:  Explicit null dereferenced  (FORWARD_NULL)
/sys/external/bsd/drm2/dist/drm/radeon/r100.c: 1006 in r100_cp_init_microcode()

** CID 113848:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 232 in r420_cp_errata_fini()

** CID 113849:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 218 in r420_cp_errata_init()

** CID 113850:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 217 in r420_cp_errata_init()

** CID 114138:  Operands don't affect result  (CONSTANT_EXPRESSION_RESULT)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_legacy_crtc.c: 327 in radeon_crtc_dpms()

** CID 114250:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_fb.c: 154 in radeonfb_create_pinned_object()
/sys/external/bsd/drm2/dist/drm/radeon/radeon_fb.c: 189 in radeonfb_create_pinned_object()

** CID 114251:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_fb.c: 169 in radeonfb_create_pinned_object()

** CID 114733:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/ttm/ttm_bo.c: 268 in ttm_bo_add_ttm()

** CID 114734:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 113 in r420_pipes_init()

** CID 139353:  Untrusted value as argument  (TAINTED_SCALAR)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_cs.c: 327 in radeon_cs_parser_init()
/sys/external/bsd/drm2/dist/drm/radeon/radeon_cs.c: 327 in radeon_cs_parser_init()
/sys/external/bsd/drm2/dist/drm/radeon/radeon_cs.c: 327 in radeon_cs_parser_init()

** CID 139583:  Uninitialized scalar variable  (UNINIT)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_atombios.c: 532 in radeon_get_atom_connector_info_from_object_table()

** CID 139798:  Unused value  (UNUSED_VALUE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_ttm.c: 345 in radeon_move_ram_vram()

** CID 139799:  Unused value  (UNUSED_VALUE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_ttm.c: 298 in radeon_move_vram_ram()

** CID 141373:  Buffer not null terminated  (BUFFER_SIZE_WARNING)
/sys/external/bsd/drm2/dist/drm/i915/intel_tv.c: 1415 in intel_tv_get_modes()

** CID 141381:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/i915/intel_sdvo.c: 2928 in intel_sdvo_create_enhance_property()

** CID 141382:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_pm.c: 291 in radeon_pm_set_clocks()

** CID 141432:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/i915/intel_sdvo.c: 2275 in intel_sdvo_guess_ddc_bus()

** CID 141433:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/i915/intel_sdvo.c: 2269 in intel_sdvo_guess_ddc_bus()


________________________________________________________________________________________________________
*** CID 113228:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/atombios_crtc.c: 136 in atombios_scaler_setup()
130     		case TV_STD_PAL_CN:
131     			args.ucTVStandard = ATOM_TV_PALCN;
132     			break;
133     		}
134     		args.ucEnable = SCALER_ENABLE_MULTITAP_MODE;
135     	} else if (is_cv) {
>>>     CID 113228:  Logically dead code  (DEADCODE)
>>>     Execution cannot reach this statement "args.ucTVStandard = 16;".
136     		args.ucTVStandard = ATOM_TV_CV;
137     		args.ucEnable = SCALER_ENABLE_MULTITAP_MODE;
138     	} else {
139     		switch (radeon_crtc->rmx_type) {
140     		case RMX_FULL:
141     			args.ucEnable = ATOM_SCALER_EXPANSION;

________________________________________________________________________________________________________
*** CID 113231:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_atombios.c: 972 in radeon_get_atom_connector_info_from_supported_devices_table()
966     			bios_connectors[i].ddc_bus.valid = false;
967     			bios_connectors[i].line_mux = 50;
968     		} else if (i == ATOM_DEVICE_TV2_INDEX) {
969     			bios_connectors[i].ddc_bus.valid = false;
970     			bios_connectors[i].line_mux = 51;
971     		} else if (i == ATOM_DEVICE_CV_INDEX) {
>>>     CID 113231:  Logically dead code  (DEADCODE)
>>>     Execution cannot reach this statement "(bios_connectors + i).ddc_b...".
972     			bios_connectors[i].ddc_bus.valid = false;
973     			bios_connectors[i].line_mux = 52;
974     		} else
975     			bios_connectors[i].ddc_bus =
976     			    radeon_lookup_i2c_gpio(rdev,
977     						   bios_connectors[i].line_mux);

________________________________________________________________________________________________________
*** CID 113251:  Explicit null dereferenced  (FORWARD_NULL)
/sys/external/bsd/drm2/dist/drm/radeon/r100.c: 1006 in r100_cp_init_microcode()
1000     }
1001     
1002     
1003     /* Load the microcode for the CP */
1004     static int r100_cp_init_microcode(struct radeon_device *rdev)
1005     {
>>>     CID 113251:  Explicit null dereferenced  (FORWARD_NULL)
>>>     Assigning: "fw_name" = "NULL".
1006     	const char *fw_name = NULL;
1007     	int err;
1008     
1009     	DRM_DEBUG_KMS("\n");
1010     
1011     	if ((rdev->family == CHIP_R100) || (rdev->family == CHIP_RV100) ||

________________________________________________________________________________________________________
*** CID 113848:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 232 in r420_cp_errata_fini()
226     {
227     	struct radeon_ring *ring = &rdev->ring[RADEON_RING_TYPE_GFX_INDEX];
228     
229     	/* Catch the RESYNC we dispatched all the way back,
230     	 * at the very beginning of the CP init.
231     	 */
>>>     CID 113848:  Unchecked return value  (CHECKED_RETURN)
>>>     No check of the return value of "radeon_ring_lock(rdev, ring, 8U)".
232     	radeon_ring_lock(rdev, ring, 8);
233     	radeon_ring_write(ring, PACKET0(R300_RB3D_DSTCACHE_CTLSTAT, 0));
234     	radeon_ring_write(ring, R300_RB3D_DC_FINISH);
235     	radeon_ring_unlock_commit(rdev, ring);
236     	radeon_scratch_free(rdev, rdev->config.r300.resync_scratch);
237     }

________________________________________________________________________________________________________
*** CID 113849:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 218 in r420_cp_errata_init()
212     	 * while the 2D engine is busy.
213     	 *
214     	 * The proper workaround is to queue a RESYNC at the beginning
215     	 * of the CP init, apparently.
216     	 */
217     	radeon_scratch_get(rdev, &rdev->config.r300.resync_scratch);
>>>     CID 113849:  Unchecked return value  (CHECKED_RETURN)
>>>     No check of the return value of "radeon_ring_lock(rdev, ring, 8U)".
218     	radeon_ring_lock(rdev, ring, 8);
219     	radeon_ring_write(ring, PACKET0(R300_CP_RESYNC_ADDR, 1));
220     	radeon_ring_write(ring, rdev->config.r300.resync_scratch);
221     	radeon_ring_write(ring, 0xDEADBEEF);
222     	radeon_ring_unlock_commit(rdev, ring);
223     }

________________________________________________________________________________________________________
*** CID 113850:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 217 in r420_cp_errata_init()
211     	/* RV410 and R420 can lock up if CP DMA to host memory happens
212     	 * while the 2D engine is busy.
213     	 *
214     	 * The proper workaround is to queue a RESYNC at the beginning
215     	 * of the CP init, apparently.
216     	 */
>>>     CID 113850:  Unchecked return value  (CHECKED_RETURN)
>>>     No check of the return value of "radeon_scratch_get(rdev, &rdev->config.r300.resync_scratch)".
217     	radeon_scratch_get(rdev, &rdev->config.r300.resync_scratch);
218     	radeon_ring_lock(rdev, ring, 8);
219     	radeon_ring_write(ring, PACKET0(R300_CP_RESYNC_ADDR, 1));
220     	radeon_ring_write(ring, rdev->config.r300.resync_scratch);
221     	radeon_ring_write(ring, 0xDEADBEEF);
222     	radeon_ring_unlock_commit(rdev, ring);

________________________________________________________________________________________________________
*** CID 114138:  Operands don't affect result  (CONSTANT_EXPRESSION_RESULT)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_legacy_crtc.c: 327 in radeon_crtc_dpms()
321     	switch (mode) {
322     	case DRM_MODE_DPMS_ON:
323     		radeon_crtc->enabled = true;
324     		/* adjust pm to dpms changes BEFORE enabling crtcs */
325     		radeon_pm_compute_clocks(rdev);
326     		if (radeon_crtc->crtc_id)
>>>     CID 114138:  Operands don't affect result  (CONSTANT_EXPRESSION_RESULT)
>>>     "(33554432U /* 1 << 25 */) & ~~((33554432U /* 1 << 25 */) | mask)" is always 0x2000000 regardless of the values of its operands. This occurs as the bitwise operand of '|='.
327     			WREG32_P(RADEON_CRTC2_GEN_CNTL, RADEON_CRTC2_EN, ~(RADEON_CRTC2_EN | mask));
328     		else {
329     			WREG32_P(RADEON_CRTC_GEN_CNTL, RADEON_CRTC_EN, ~(RADEON_CRTC_EN |
330     									 RADEON_CRTC_DISP_REQ_EN_B));
331     			WREG32_P(RADEON_CRTC_EXT_CNTL, crtc_ext_cntl, ~(mask | crtc_ext_cntl));
332     		}

________________________________________________________________________________________________________
*** CID 114250:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_fb.c: 154 in radeonfb_create_pinned_object()
148     		       aligned_size);
149     		return -ENOMEM;
150     	}
151     	rbo = gem_to_radeon_bo(gobj);
152     
153     	if (fb_tiled)
>>>     CID 114250:  Logically dead code  (DEADCODE)
>>>     Execution cannot reach this statement "tiling_flags = 1U;".
154     		tiling_flags = RADEON_TILING_MACRO;
155     
156     #ifdef __BIG_ENDIAN
157     	switch (bpp) {
158     	case 32:
159     		tiling_flags |= RADEON_TILING_SWAP_32BIT;
/sys/external/bsd/drm2/dist/drm/radeon/radeon_fb.c: 189 in radeonfb_create_pinned_object()
183     				       NULL);
184     	if (ret) {
185     		radeon_bo_unreserve(rbo);
186     		goto out_unref;
187     	}
188     	if (fb_tiled)
>>>     CID 114250:  Logically dead code  (DEADCODE)
>>>     Execution cannot reach this statement "radeon_bo_check_tiling(rbo,...".
189     		radeon_bo_check_tiling(rbo, 0, 0);
190     	ret = radeon_bo_kmap(rbo, NULL);
191     	radeon_bo_unreserve(rbo);
192     	if (ret) {
193     		goto out_unref;
194     	}

________________________________________________________________________________________________________
*** CID 114251:  Logically dead code  (DEADCODE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_fb.c: 169 in radeonfb_create_pinned_object()
163     	default:
164     		break;
165     	}
166     #endif
167     
168     	if (tiling_flags) {
>>>     CID 114251:  Logically dead code  (DEADCODE)
>>>     Execution cannot reach this statement "ret = radeon_bo_set_tiling_...".
169     		ret = radeon_bo_set_tiling_flags(rbo,
170     						 tiling_flags | RADEON_TILING_SURFACE,
171     						 mode_cmd->pitches[0]);
172     		if (ret)
173     			dev_err(rdev->dev, "FB failed to set tiling flags\n");
174     	}

________________________________________________________________________________________________________
*** CID 114733:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/ttm/ttm_bo.c: 268 in ttm_bo_add_ttm()
262     		page_flags |= TTM_PAGE_FLAG_DMA32;
263     
264     	switch (bo->type) {
265     	case ttm_bo_type_device:
266     		if (zero_alloc)
267     			page_flags |= TTM_PAGE_FLAG_ZERO_ALLOC;
>>>     CID 114733:  Missing break in switch  (MISSING_BREAK)
>>>     The above case falls through to this one.
268     	case ttm_bo_type_kernel:
269     		bo->ttm = bdev->driver->ttm_tt_create(bdev, bo->num_pages << PAGE_SHIFT,
270     						      page_flags, glob->dummy_read_page);
271     		if (unlikely(bo->ttm == NULL))
272     			ret = -ENOMEM;
273     		break;

________________________________________________________________________________________________________
*** CID 114734:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/radeon/r420.c: 113 in r420_pipes_init()
107     	rdev->num_gb_pipes = num_pipes;
108     	tmp = 0;
109     	switch (num_pipes) {
110     	default:
111     		/* force to 1 pipe */
112     		num_pipes = 1;
>>>     CID 114734:  Missing break in switch  (MISSING_BREAK)
>>>     The above case falls through to this one.
113     	case 1:
114     		tmp = (0 << 1);
115     		break;
116     	case 2:
117     		tmp = (3 << 1);
118     		break;

________________________________________________________________________________________________________
*** CID 139353:  Untrusted value as argument  (TAINTED_SCALAR)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_cs.c: 327 in radeon_cs_parser_init()
321     
322     		p->chunks[i].kdata = drm_malloc_ab(size, sizeof(uint32_t));
323     		size *= sizeof(uint32_t);
324     		if (p->chunks[i].kdata == NULL) {
325     			return -ENOMEM;
326     		}
>>>     CID 139353:  Untrusted value as argument  (TAINTED_SCALAR)
>>>     Passing tainted variable "size" to a tainted sink.
327     		if (copy_from_user(p->chunks[i].kdata, cdata, size)) {
328     			return -EFAULT;
329     		}
330     		if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS) {
331     			p->cs_flags = p->chunks[i].kdata[0];
332     			if (p->chunks[i].length_dw > 1)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_cs.c: 327 in radeon_cs_parser_init()
321     
322     		p->chunks[i].kdata = drm_malloc_ab(size, sizeof(uint32_t));
323     		size *= sizeof(uint32_t);
324     		if (p->chunks[i].kdata == NULL) {
325     			return -ENOMEM;
326     		}
>>>     CID 139353:  Untrusted value as argument  (TAINTED_SCALAR)
>>>     Passing tainted variable "size" to a tainted sink.
327     		if (copy_from_user(p->chunks[i].kdata, cdata, size)) {
328     			return -EFAULT;
329     		}
330     		if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS) {
331     			p->cs_flags = p->chunks[i].kdata[0];
332     			if (p->chunks[i].length_dw > 1)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_cs.c: 327 in radeon_cs_parser_init()
321     
322     		p->chunks[i].kdata = drm_malloc_ab(size, sizeof(uint32_t));
323     		size *= sizeof(uint32_t);
324     		if (p->chunks[i].kdata == NULL) {
325     			return -ENOMEM;
326     		}
>>>     CID 139353:  Untrusted value as argument  (TAINTED_SCALAR)
>>>     Passing tainted variable "size" to a tainted sink.
327     		if (copy_from_user(p->chunks[i].kdata, cdata, size)) {
328     			return -EFAULT;
329     		}
330     		if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS) {
331     			p->cs_flags = p->chunks[i].kdata[0];
332     			if (p->chunks[i].length_dw > 1)

________________________________________________________________________________________________________
*** CID 139583:  Uninitialized scalar variable  (UNINIT)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_atombios.c: 532 in radeon_get_atom_connector_info_from_object_table()
526     	ATOM_DISPLAY_OBJECT_PATH_TABLE *path_obj;
527     	ATOM_OBJECT_HEADER *obj_header;
528     	int i, j, k, path_size, device_support;
529     	int connector_type;
530     	u16 igp_lane_info, conn_id, connector_object_id;
531     	struct radeon_i2c_bus_rec ddc_bus;
>>>     CID 139583:  Uninitialized scalar variable  (UNINIT)
>>>     Declaring variable "router" without initializer.
532     	struct radeon_router router;
533     	struct radeon_gpio_rec gpio;
534     	struct radeon_hpd hpd;
535     
536     	if (!atom_parse_data_header(ctx, index, &size, &frev, &crev, &data_offset))
537     		return false;

________________________________________________________________________________________________________
*** CID 139798:  Unused value  (UNUSED_VALUE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_ttm.c: 345 in radeon_move_ram_vram()
339     	struct ttm_mem_reg *old_mem = &bo->mem;
340     	struct ttm_mem_reg tmp_mem;
341     	struct ttm_placement placement;
342     	u32 placements;
343     	int r;
344     
>>>     CID 139798:  Unused value  (UNUSED_VALUE)
>>>     Pointer "rdev" returned by "radeon_get_rdev(bo->bdev)" is never used.
345     	rdev = radeon_get_rdev(bo->bdev);
346     	tmp_mem = *new_mem;
347     	tmp_mem.mm_node = NULL;
348     	placement.fpfn = 0;
349     	placement.lpfn = 0;
350     	placement.num_placement = 1;

________________________________________________________________________________________________________
*** CID 139799:  Unused value  (UNUSED_VALUE)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_ttm.c: 298 in radeon_move_vram_ram()
292     	struct ttm_mem_reg *old_mem = &bo->mem;
293     	struct ttm_mem_reg tmp_mem;
294     	u32 placements;
295     	struct ttm_placement placement;
296     	int r;
297     
>>>     CID 139799:  Unused value  (UNUSED_VALUE)
>>>     Pointer "rdev" returned by "radeon_get_rdev(bo->bdev)" is never used.
298     	rdev = radeon_get_rdev(bo->bdev);
299     	tmp_mem = *new_mem;
300     	tmp_mem.mm_node = NULL;
301     	placement.fpfn = 0;
302     	placement.lpfn = 0;
303     	placement.num_placement = 1;

________________________________________________________________________________________________________
*** CID 141373:  Buffer not null terminated  (BUFFER_SIZE_WARNING)
/sys/external/bsd/drm2/dist/drm/i915/intel_tv.c: 1415 in intel_tv_get_modes()
1409     					&& !tv_mode->component_only))
1410     			continue;
1411     
1412     		mode_ptr = drm_mode_create(connector->dev);
1413     		if (!mode_ptr)
1414     			continue;
>>>     CID 141373:  Buffer not null terminated  (BUFFER_SIZE_WARNING)
>>>     Calling strncpy with a maximum size argument of 32 bytes on destination array "mode_ptr->name" of size 32 bytes might leave the destination string unterminated.
1415     		strncpy(mode_ptr->name, input->name, DRM_DISPLAY_MODE_LEN);
1416     
1417     		mode_ptr->hdisplay = hactive_s;
1418     		mode_ptr->hsync_start = hactive_s + 1;
1419     		mode_ptr->hsync_end = hactive_s + 64;
1420     		if (mode_ptr->hsync_end <= mode_ptr->hsync_start)

________________________________________________________________________________________________________
*** CID 141381:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/i915/intel_sdvo.c: 2928 in intel_sdvo_create_enhance_property()
2922     		uint16_t response;
2923     	} enhancements;
2924     
2925     	BUILD_BUG_ON(sizeof(enhancements) != 2);
2926     
2927     	enhancements.response = 0;
>>>     CID 141381:  Unchecked return value  (CHECKED_RETURN)
>>>     No check of the return value of "intel_sdvo_get_value(intel_sdvo, 132, &enhancements, 2)".
2928     	intel_sdvo_get_value(intel_sdvo,
2929     			     SDVO_CMD_GET_SUPPORTED_ENHANCEMENTS,
2930     			     &enhancements, sizeof(enhancements));
2931     	if (enhancements.response == 0) {
2932     		DRM_DEBUG_KMS("No enhancement is supported\n");
2933     		return true;

________________________________________________________________________________________________________
*** CID 141382:  Unchecked return value  (CHECKED_RETURN)
/sys/external/bsd/drm2/dist/drm/radeon/radeon_pm.c: 291 in radeon_pm_set_clocks()
285     	radeon_unmap_vram_bos(rdev);
286     
287     	if (rdev->irq.installed) {
288     		for (i = 0; i < rdev->num_crtc; i++) {
289     			if (rdev->pm.active_crtcs & (1 << i)) {
290     				rdev->pm.req_vblank |= (1 << i);
>>>     CID 141382:  Unchecked return value  (CHECKED_RETURN)
>>>     No check of the return value of "drm_vblank_get(rdev->ddev, i)".
291     				drm_vblank_get(rdev->ddev, i);
292     			}
293     		}
294     	}
295     
296     	radeon_set_power_state(rdev);

________________________________________________________________________________________________________
*** CID 141432:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/i915/intel_sdvo.c: 2275 in intel_sdvo_guess_ddc_bus()
2269     	case SDVO_OUTPUT_LVDS0:
2270     		mask |= SDVO_OUTPUT_LVDS0;
2271     	case SDVO_OUTPUT_TMDS1:
2272     		mask |= SDVO_OUTPUT_TMDS1;
2273     	case SDVO_OUTPUT_TMDS0:
2274     		mask |= SDVO_OUTPUT_TMDS0;
>>>     CID 141432:  Missing break in switch  (MISSING_BREAK)
>>>     The above case falls through to this one.
2275     	case SDVO_OUTPUT_RGB1:
2276     		mask |= SDVO_OUTPUT_RGB1;
2277     	case SDVO_OUTPUT_RGB0:
2278     		mask |= SDVO_OUTPUT_RGB0;
2279     		break;
2280     	}

________________________________________________________________________________________________________
*** CID 141433:  Missing break in switch  (MISSING_BREAK)
/sys/external/bsd/drm2/dist/drm/i915/intel_sdvo.c: 2269 in intel_sdvo_guess_ddc_bus()
2263     	/* Make a mask of outputs less than or equal to our own priority in the
2264     	 * list.
2265     	 */
2266     	switch (sdvo->controlled_output) {
2267     	case SDVO_OUTPUT_LVDS1:
2268     		mask |= SDVO_OUTPUT_LVDS1;
>>>     CID 141433:  Missing break in switch  (MISSING_BREAK)
>>>     The above case falls through to this one.
2269     	case SDVO_OUTPUT_LVDS0:
2270     		mask |= SDVO_OUTPUT_LVDS0;
2271     	case SDVO_OUTPUT_TMDS1:
2272     		mask |= SDVO_OUTPUT_TMDS1;
2273     	case SDVO_OUTPUT_TMDS0:
2274     		mask |= SDVO_OUTPUT_TMDS0;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/1450?tab=overview

To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py




Home | Main Index | Thread Index | Old Index