-Werror=unused-but-set-variable

[Emmanuel Fleury <fleury%labri.fr@localhost>]

Hi,

I'm hitting a build error when trying to compile atf with gcc 4.6.1.

$ gcc --version
gcc (Debian 4.6.1-6) 4.6.1

While executing: autoreconf -is && ./configure && make

I have the following error:

atf-c/check.c: In function 'atf_check_result_init':
atf-c/check.c:304:17: error: variable 'workdir' set but not used
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors

make[1]: *** [atf-c/libatf_c_la-check.lo] Error 1
make[1]: Leaving directory `/home/fleury/tmp/atf-dev/src'
make: *** [all] Error 2

In my humble opinion, you should add -Wno-unused to the compile flags to
avoid unused variables/functions/... detection.

For now I didn't manage to add the additional flags to the build-system.
It seems that using the ATF_BUILD_CFLAGS (and ATF_BUILD_CXXFLAGS) is not
enough.

So, a bit of help could be helpful. :)

Regards
-- 
Emmanuel Fleury

`The first ten million years were the worst,' said Marvin,
`and the second ten million, they were the worst too.
 The third ten million I didn't enjoy at all.
 After that I went into a bit of a decline.'
  -- Guess who... (Douglas Adams)