In article <20051123131455.GA7345@lori.mine.nu> Geert wrote:
: [-- text/plain, encoding 7bit, charset: us-ascii, 15 lines --]

: On Wed, Nov 23, 2005 at 12:13:51PM +0100, Quentin Garnier wrote:
: > > > the "ts" modifier cannot be used since it's not supported by the
: > > > make(1) shipped with netbsd-1-6.
: > > 
: > > Heh, then how should we fix this?  The package currently uses
: > > MODULES:=${MODULES}:foo but this way MODULES starts with a colon which
: > > confuses the configure script...  
: > 
: > Pass ${MODULES:C/^://}.

: Good idea.  Here's the patch to implement it that way + OPTION'ize the
: modules.  

  Looks good, just two points:

: -PKG_OPTIONS_VAR       = PKG_OPTIONS.proftpd
: -PKG_SUPPORTED_OPTIONS = pam wrap quota
: +PKG_OPTIONS_VAR=       PKG_OPTIONS.proftpd
: +PKG_SUPPORTED_OPTIONS= pam wrap quota ldap mysql pgsql readme

  Please use the option name proftpd-readme, it is package specific.

: +PKG_OPTIONS_LEGACY_VARS+=      PROFTPD_USE_LDAP:ldap
: +PKG_OPTIONS_LEGACY_VARS+=      PROFTPD_USE_MYSQL:mysql
: +PKG_OPTIONS_LEGACY_VARS+=      PROFTPD_USE_POSTGRES:pgsql
: +PKG_OPTIONS_LEGACY_VARS+=      PROFTPD_USE_README:readme

  Please add a comment when these may be removed (after 2005Q4 or
2006Q1 branch).

					yours,
					dillo