tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?



On Mon, 8 Nov 2021, Jason Thorpe wrote:

On Nov 7, 2021, at 11:07 PM, RVP <rvp%SDF.ORG@localhost> wrote:

So, I hacked up a small patch to put most of these into the
"if_iqdrops" bucket. The rest (following FreeBSD) remain as errors.

LGTM!


On Mon, 8 Nov 2021, Christos Zoulas wrote:

As far as I'm concerned, you can silently chuck most of these errors
away--like FreeBSD does, or classify them as "dropped" like Linux does.
Either way is fine with me--just not "if_ierrors": that's too confusing.

I think that the patch makes sense...


OK, so discarded packets are fine as `if_iqdrops'. Otherwise, a kernel w/o
vlan (or netatalk, carp, ...) compiled in will show:

$ ifconfig -v alc0
alc0: flags=0x8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        ec_capabilities=0x1<VLAN_MTU>
        ec_enabled=0
        address: 50:46:5d:32:67:54
        media: Ethernet autoselect (100baseTX full-duplex,flowcontrol,rxpause,txpause)
        status: active
        input: 2502 packets, 488042 bytes, 1935 multicasts, 821 queue drops
        output: 611 packets, 133649 bytes, 43 multicasts
        inet6 fe80::5246:5dff:fe32:6754%alc0/64 flags 0 scopeid 0x1
        inet 192.168.68.121/24 broadcast 192.168.68.255 flags 0
$

Maybe we should have a separate `if_idiscard'? Or is that too fine a
distinction?

Thanks,
-RVP


Home | Main Index | Thread Index | Old Index