Subject: Re: KNF for i386 pmap new?
To: Gandhi woulda smacked you <greywolf@starwolf.com>
From: Thor Lancelot Simon <tls@rek.tjls.com>
List: tech-kern
Date: 05/05/1999 13:13:56
On Wed, May 05, 1999 at 12:21:16AM -0700, Gandhi woulda smacked you wrote:
> On Wed, 5 May 1999, matthew green wrote:
>
> #
> # Is there a reason why the i386 version of pmap-new is not KNF'd? I just
> # had a look at Chuck's resident count changes and noticed this...
> #
> #
> # chuck doesn't like KNF.
>
> My reply was going to be a lot more rude but it's late so suffice to say
> that rule #1 of porting or hacking applies here:
>
> "If you're gonna play in the big sandbox, it's generally considered bad
> form to kick down someone else's sandcastle to build your own."
>
> In short, if you're coding within an existing project, try to keep with
> style, even if it repulses you.
You have clearly never closely examined the original Hibler VM code.